Passing parent stack frames to spawn-helper functions #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to helper functions.
…o spawn-helper functions, to simply pass the stackframe as the last argument.
…ck frame pointers to spawn helpers.
|
This looks good, except I want a better comment around the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drafts compiler changes to pass a pointer to the
__cilkrts_stack_framein a parent spawning function, along with other compile-time information, to a spawn helper. This change allows the spawn helper to access the parent stack frame more efficiently and enables a variety of optimizations to reduce spawn overhead.This PR provides the necessary compiler changes for PR OpenCilk/cheetah#29.