Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set memory(read) instead of readonly on strand_pure function definition #205

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Set memory(read) instead of readonly on strand_pure function definition #205

merged 1 commit into from
Oct 18, 2023

Conversation

VoxSciurorum
Copy link
Contributor

Without this change the IR Verifier fails on a function definition with the strand_pure C attribute.

@VoxSciurorum VoxSciurorum requested a review from neboat October 10, 2023 19:37
@VoxSciurorum VoxSciurorum changed the title Set memory(none) instead of readonly on strand_pure function definition Set memory(read) instead of readonly on strand_pure function definition Oct 13, 2023
neboat
neboat approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@neboat neboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

@neboat neboat merged commit e22b0d1 into dev/16.x Oct 18, 2023
3 checks passed
@VoxSciurorum VoxSciurorum deleted the jfc/readonly branch December 31, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neboat neboat neboat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VoxSciurorum @neboat