Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth error code and some unit tests #201

Merged
merged 15 commits into from
Dec 9, 2024
Merged

auth error code and some unit tests #201

merged 15 commits into from
Dec 9, 2024

Conversation

Rader
Copy link
Collaborator

@Rader Rader commented Dec 9, 2024

What is this feature?

two major changes:

  • repo's LastCommit and Tree api use 403 error instead of 401 if user has no permission to access the repo
  • some unit test for user, sensitive checking related

Why do we need this feature?

  • auth code 403 tell the client to show error message instead of ask user to login
  • unit test for better code quality

Who is this feature for?

N/A

Which issue(s) does this PR fix?:

N/A

Special notes for your reviewer:

@starship-github
Copy link

🚀 The StarShip CodeReviewer has been triggered with action(s): review, evaluate, describe, linter.

@Yiling-J Yiling-J self-requested a review December 9, 2024 08:09
@Rader Rader merged commit 27431f7 into main Dec 9, 2024
4 checks passed
@Rader Rader deleted the cp-ut branch December 9, 2024 08:11
@starship-github
Copy link

The StarShip CodeReviewer was triggered but terminated because it encountered an issue: The MR state is not opened.

Tips

CodeReview Commands (invoked as MR or PR comments)

  • @codegpt /review to trigger an code review.
  • @codegpt /evaluate to trigger code evaluation process.
  • @codegpt /describe to regenerate the summary of the MR.
  • @codegpt /secscan to scan security vulnerabilities for the MR or the Repository.
  • @codegpt /help to get help.

CodeReview Discussion Chat

There are 2 ways to chat with Starship CodeReview:

  • Review comments: Directly reply to a review comment made by StarShip.
    Example:
    • @codegpt How to fix this bug?
  • Files and specific lines of code (under the "Files changed" tab):
    Tag @codegpt in a new review comment at the desired location with your query.
    Examples:
    • @codegpt generate unit testing code for this code snippet.

Note: Be mindful of the bot's finite context window.
It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.
For a focused discussion, use review comments to chat about specific files and their changes, instead of using the MR/PR comments.

CodeReview Documentation and Community

  • Visit our Documentation
    for detailed information on how to use Starship CodeReview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants