Merge branch 'fix/exec_workflow' into 'main'

Fix temporal workflow run param See merge request product/starhub/starhub-server!782
OpenCSGs · Jan 3, 2025 · 162e160 · 162e160
1 parent b758a8b
commit 162e160
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/api/handler/callback/git_callback.go b/api/handler/callback/git_callback.go
@@ -54,9 +54,8 @@ func (h *GitCallbackHandler) handlePush(c *gin.Context) {
 		TaskQueue: workflow.HandlePushQueueName,
 	}
 
-	we, err := workflowClient.ExecuteWorkflow(c, workflowOptions, workflow.HandlePushWorkflow,
-		&req,
-		h.config,
+	we, err := workflowClient.ExecuteWorkflow(
+		c, workflowOptions, workflow.HandlePushWorkflow, &req,
 	)
 	if err != nil {
 		slog.Error("failed to handle git push callback", slog.Any("error", err))

diff --git a/api/handler/internal.go b/api/handler/internal.go
@@ -143,9 +143,8 @@ func (h *InternalHandler) PostReceive(ctx *gin.Context) {
 		TaskQueue: workflow.HandlePushQueueName,
 	}
 
-	we, err := h.temporalClient.ExecuteWorkflow(ctx, workflowOptions, workflow.HandlePushWorkflow,
-		callback,
-		h.config,
+	we, err := h.temporalClient.ExecuteWorkflow(
+		ctx, workflowOptions, workflow.HandlePushWorkflow, callback,
 	)
 	if err != nil {
 		slog.Error("failed to handle git push callback", slog.Any("error", err))

diff --git a/api/handler/internal_test.go b/api/handler/internal_test.go
@@ -153,7 +153,7 @@ func TestInternalHandler_PostReceive(t *testing.T) {
 		tester.ctx, client.StartWorkflowOptions{
 			TaskQueue: workflow.HandlePushQueueName,
 		}, mock.Anything,
-		&types.GiteaCallbackPushReq{Ref: "ref/heads/main"}, &config.Config{},
+		&types.GiteaCallbackPushReq{Ref: "ref/heads/main"},
 	).Return(
 		runMock, nil,
 	)

diff --git a/cmd/csghub-server/cmd/trigger/git_callback.go b/cmd/csghub-server/cmd/trigger/git_callback.go
@@ -92,9 +92,8 @@ var gitCallbackCmd = &cobra.Command{
 				TaskQueue: workflow.HandlePushQueueName,
 			}
 
-			we, err := workflowClient.ExecuteWorkflow(context.Background(), workflowOptions, workflow.HandlePushWorkflow,
-				req,
-				config,
+			we, err := workflowClient.ExecuteWorkflow(
+				context.Background(), workflowOptions, workflow.HandlePushWorkflow, req,
 			)
 			if err != nil {
 				slog.Error("failed to handle git push callback", slog.String("repo", repo.Path), slog.Any("error", err))

diff --git a/mirror/reposyncer/local_woker.go b/mirror/reposyncer/local_woker.go
@@ -233,9 +233,8 @@ func (w *LocalMirrorWoker) SyncRepo(ctx context.Context, task queue.MirrorTask)
 		TaskQueue: workflow.HandlePushQueueName,
 	}
 
-	we, err := workflowClient.ExecuteWorkflow(ctx, workflowOptions, workflow.HandlePushWorkflow,
-		callback,
-		w.config,
+	we, err := workflowClient.ExecuteWorkflow(
+		ctx, workflowOptions, workflow.HandlePushWorkflow, callback,
 	)
 	if err != nil {
 		return fmt.Errorf("failed to handle git push callback: %w", err)