Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: starting (simple) online multiplier support #24

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

Draft: starting (simple) online multiplier support #24

wants to merge 47 commits into from
+1,874 −151

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented Apr 5, 2023 •
edited
Loading

Tasks before this ready:

  • extensive SDL_net wrapper for easy to use struct transmission over network
  • basic Local Multiplayer (on localhost)
  • improve code consistency and resolve (resolvable) TODOs
  • correctly transport the start state (seed)
  • rebase merge (it was fun 😂)
  • fix crash that was introduced in merging
  • refactor (e.g. use [[nodiscard]], find better names ...) WIP
  • add docs WIP
  • merge v2 (:sob:)
  • merge v3 (:sob: :sob:)

Totto16 added 30 commits April 5, 2023 17:46
@Totto16
WIP: starting online multiplier support
19f7b3d
@Totto16
added SDL2 Wrapper classes
19631be
@Totto16
implemented PlayerManager
579204d
@Totto16
implemented serialization of Transportable
18595a8
@Totto16
more features added, client and server can connect (but still not com…
eb391fe 
…municate correctly)
@Totto16
deleted unused code
26f93e5
@Totto16
fixed issues in offsets and in event_dispatching, now it works visual…
b2271e9 
…ly (input receiveing isn't implemented yet)
@Totto16
added ability to deserialize (WIP)
60783f9
@Totto16
added source files to cmake
851c79f
@Totto16
added correct header so that msvc doesn't complain
6e2699f
@Totto16
fixed meson CI (linux) to use gcc-12
8711790
@Totto16
fixed msvc warning (error)
95ed3a3
@Totto16
fix more msvc errors
4ea8f0b
@Totto16
- fixed consistency with std::uint32_t and uint32_t
cf8f219 
- fixed a few templates
- remove  free floating templates / functions
@Totto16
- fixed many free floating templates
d878672 
- made working with raw network sent data easier
- fixed ownership of received data
@Totto16
fixed draw position of the preview field
e28ff19
@Totto16
fixed sending data, now each client can send its inputs (but the star…
1e3ef32 
…t piece differs xD)
@Totto16
replaced c-like casts with static_cats where possible
ce7151b
@Totto16
fixed so that also the client can receive data
1b25223
@Totto16
added latest_sdl_net_error util
d0fb288
@Totto16
fixed crash, where iI used the wrong variable
5fbda19
@Totto16
added better initialization (WIP), untested
d89ef53
@Totto16
removed unnecessary debug printing
32eacbd
@Totto16
fixed remaining bugs:
1197a8e 
- fixed return value errors (dont use {}, use tl::nullopt, if you want to use a null optional!)
 fixed some receive - send errors
@Totto16
fixed todo: removed assert and replace it with throw
e5cd7e0
@Totto16
refined todo
0565a31
@Totto16
fixed todo:
db2194c 
- use tl::expected instead of exception
@Totto16
removed todo:
ba482bf 
- throw on wrong implementation of LocalMultiplayer::init
@Totto16
refined todo
b2f49ff
@Totto16
added GCC warning -Wold-style-cast
30ed3f3 
- fixed teh resulting warnings
@Totto16 Totto16 marked this pull request as ready for review April 8, 2023 00:11
@Totto16 Totto16 changed the title Draft: starting (simple) online multiplier support starting (simple) online multiplier support Apr 8, 2023
@Totto16 Totto16 changed the title starting (simple) online multiplier support Draft: starting (simple) online multiplier support Apr 10, 2023
@Totto16 Totto16 marked this pull request as draft April 10, 2023 15:26
@mgerhold mgerhold linked an issue Apr 13, 2023 that may be closed by this pull request
implement multiplayer basics #71
Open
@Totto16 Totto16 mentioned this pull request Apr 13, 2023
Open
Totto16 added 5 commits April 16, 2023 22:19
@Totto16
Merge remote-tracking branch 'upstream/main' into network-impl
b08ce2b 
- also fixed merge errors and conflicts that came out of the merge
@Totto16
removed technical debt:
8667c2f 
- remove helper function that was used during debugging of a crash
@Totto16
refactor and review Connection and Server class:
b31b66b 
- added [[nodiscard]] where it's usefull and makes sense
- started with docs
- refactored some API for better convenience in use
@Totto16
deleted copy constructor cause copying sockets would cause false beha…
3b2a8e9 
…viour!
@Totto16
refined Connection class docs
66c0a01
@Totto16 Totto16 added the stale This is stale for a long time label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale This is stale for a long time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement multiplayer basics
1 participant
@Totto16