Skip to content

Commit

Permalink
ci: fix lint action
Browse files Browse the repository at this point in the history
  • Loading branch information
Totto16 committed Oct 30, 2024
1 parent 0431302 commit 5078b4b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/discord/core.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#pragma once

#include <core/helper/expected.hpp>
#include <core/helper/types.hpp>

#include "../helper/windows.hpp"

Expand All @@ -26,7 +27,8 @@ namespace constants::discord {
#elif defined(__CONSOLE__)
#error "Not supported"
#elif defined(FLATPAK_BUILD)
constexpr const char* platform_dependent_launch_arguments = "flatpak run io.github.openbrickprotocolfoundation.oopetris --discord";
constexpr const char* platform_dependent_launch_arguments =
"flatpak run io.github.openbrickprotocolfoundation.oopetris --discord";
#elif defined(WIN32) || defined(_WIN32) || defined(__WIN32__) || defined(__NT__)
constexpr const char* platform_dependent_launch_arguments = "oopetris.exe --discord";
#elif defined(__APPLE__)
Expand All @@ -38,7 +40,7 @@ namespace constants::discord {
#endif

// manually synchronized to https://discord.com/developers/applications/1220147916371394650/rich-presence/assets
enum class ArtAsset { logo };
enum class ArtAsset : u8 { logo };

Check warning on line 43 in src/discord/core.hpp

View workflow job for this annotation

GitHub Actions / cpp-linter

src/discord/core.hpp:43:32 [readability-identifier-naming]

invalid case style for scoped enum constant 'logo'

OOPETRIS_GRAPHICS_EXPORTED [[nodiscard]] std::string get_asset_key(ArtAsset asset);

Expand Down
1 change: 1 addition & 0 deletions tools/dependencies/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ if build_application

discord_sdk_dep = dependency(
'discord-game-sdk',
allow_fallback: true,
required: not meson.is_cross_build() and get_option('build_installer'),
# only with msvc we need a static library, all others work without adding __declspec() everywhere
static: c.get_id() == 'msvc',
Expand Down

0 comments on commit 5078b4b

Please sign in to comment.