Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API endpoint to retrieve configuration properties #385

Closed
wants to merge 1 commit into from
Closed

Add API endpoint to retrieve configuration properties #385

wants to merge 1 commit into from

Conversation

apeiris
Copy link
Contributor

@apeiris apeiris commented Jul 10, 2024

Added a new API endpoint to retrieve configuration properties from the config.xml file.

Changes

  • Created an endpoint at /api/config/properties to return configuration properties as JSON.

Testing

  • Verified the endpoint returns the correct JSON structure as expected.
    -Added unit testclass ApiResourceTest

Copy link
Contributor

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@uhurusurfa
Copy link
Contributor

It is failing because the jakarta package does not support Java 8.

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/runner/work/OpenAs2App/OpenAs2App/Server/src/test/java/org/openas2/ApiResourceTest.java:[4,26] cannot access jakarta.ws.rs.core.Response
bad class file: /home/runner/.m2/repository/jakarta/ws/rs/jakarta.ws.rs-api/3.1.0/jakarta.ws.rs-api-3.1.0.jar(jakarta/ws/rs/core/Response.class)
class file has wrong version 55.0, should be 52.0
Please remove or make sure it appears in the correct subdirectory of the classpath.
[INFO] 1 error

You will have to exclude the resource test from the Java 8 run .... look in the .github/workflows/actions.yml for how it has been done for other API tests for Java 8 only

@apeiris
Copy link
Contributor Author

apeiris commented Jul 24, 2024

Close #385 and resubmit without running this specific test

@apeiris apeiris closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants