Display JDBC driver name during startup #378
Conversation
- Updated Server\pom.xml to include mssql-jdbc 12.6.2.jre11. This driver has some vulnerabilities, update as soon as they are resolved - Updated Server\config\config.xml to support MSSQL.
…e(?,?) for improved generality - The H2 database file Server/src/config/db/openas2.mv.db now includes the routine getMessagesByDateRange
| import java.sql.SQLException; | ||
| import java.sql.Statement; | ||
| import java.sql.Types; | ||
| import java.sql.*; |
There was a problem hiding this comment.
I have specifically avoided using asterisk imports in OpenAS2 for various reasons so please restore this to specific imports. Search the internet for reasons why not to use asterisk if you are interested in understanding why.
There was a problem hiding this comment.
There is no functional change to this file. Revert to HEAD for this PR.
| CallableStatement cs = conn.prepareCall("{CALL ftGetMessagesByDateRange(?,?)}"); | ||
| cs.setDate(1, Date.valueOf(map.get("startDate"))); | ||
| cs.setDate(2,Date.valueOf(map.get("endDate"))); | ||
| ResultSet rs = cs.executeQuery(); |
There was a problem hiding this comment.
This is your own custom callable.
It will not be added to OpenAS2 since the goal is to remain generic.
I assume the statement that is currently used does not work on SqlServer because it does not support the TIMESTAMP operator so instead change the statement to this and it will work on all SQL-92 and newer standards compliant database servers:
ResultSet rs = s.executeQuery("SELECT " + FIELDS.MSG_ID + ",STATE,STATUS,CREATE_DT FROM " + tableName
+ " WHERE CREATE_DT BETWEEN CAST('" + map.get("startDate").toString()
+ " 00:00:00' as TIMESTAMP) AND CAST('" + map.get("endDate").toString()
+ " 23:59:59'" as TIMESTAMP));
There was a problem hiding this comment.
There is no functional change to this file. Revert to HEAD for this PR.
| <!-- https://mvnrepository.com/artifact/com.microsoft.sqlserver/mssql-jdbc --> | ||
| <dependency> | ||
| <groupId>com.microsoft.sqlserver</groupId> | ||
| <artifactId>mssql-jdbc</artifactId> | ||
| <version>12.6.2.jre11</version> | ||
| </dependency> |
There was a problem hiding this comment.
Please remove this import as it loads a library into the installler package that most people will never use and is not part of the default OpenAS2 functionality.
Anyone wishing to use packages other than the standard packages provided by OpenAS2 should create their own wrapper installer otherwise the OpenAS2 install package will become bloated unnecessarily.
Display JDBC driver name