-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #693 add search for schema and find parameters from the backend #698
base: master
Are you sure you want to change the base?
issue #693 add search for schema and find parameters from the backend #698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR you add a lot of utility functions. A couple of notes on that:
- they are al public at the moment, so adding them adds the burden to keep/maintain/support them. In that sense, they should also get good test coverage.
- some of the seem quite tailored for the specific use case of this PR, while they are named very generically
also note that we already have parsing functionality for process definitions: e.g. see starting point openeo.internal.processes.Process.from_dict()
. I think that should eliminate the need for all these new utility functions
I think it's also important that the core goal of this PR gets unit tests coverage
The test fail because of No mock address: GET https://oeo.test/processes. Do I have to change the test and add the address or is there another way to solve it? |
this feature indeed impacts existing tests
doing |
@@ -687,3 +687,22 @@ def normalize_crs(crs: Any, *, use_pyproj: bool = True) -> Union[None, int, str] | |||
raise ValueError(f"Can not normalize CRS data {type(crs)}") | |||
|
|||
return crs | |||
|
|||
|
|||
def search_list_for_dict_key(lst: list, key: str) -> Union[dict, list]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this function to util.py, because it couldn't be imported from connection.py due to a circular import issue. Can it stay here or should it be moved elsewhere @soxofaan
#693