Add Driver trait and optional socketcan driver #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1c6615a |
Notgnoshi
force-pushed
the
ag/driver
branch
2 times, most recently
from
c005efa to
45e7e2c
Compare
Notgnoshi
commented
Aug 8, 2023
Notgnoshi
force-pushed
the
ag/driver
branch
2 times, most recently
from
6743ba1 to
63cd366
Compare
Notgnoshi
changed the title
Notgnoshi
force-pushed
the
ag/driver
branch
2 times, most recently
from
62fed95 to
6c2a036
Compare
Notgnoshi
commented
Aug 8, 2023
GwnDaan
reviewed
Aug 9, 2023
GwnDaan
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Looks good 👍🏽
Offtopic: we will probably be making more progress if we just merge PR's in at this early stage as doing it right the first time is pretty much impossible, so let's not be too picky on each other and improve everything along the way with followup PR's :)
ad3154
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➕ Additions
Drivertrait for non-blocking read/write operationsDriver