NTCAN hardware plugin #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwnDaan
added
enhancement
GwnDaan
force-pushed
the
daan/ntcan-driver
branch
4 times, most recently
from
02d0357 to
ae43c52
Compare
|
Hi all, any chance someone has time to review this PR for me? I'd like to continue work that depends on the contributed code |
|
I think my main concern from before was just that I didn't know if we could include ntcan stuff due to license issues. It looks like you're not adding |
GwnDaan
commented
Dec 10, 2024
GwnDaan
force-pushed
the
daan/ntcan-driver
branch
from
ae43c52 to
ae51168
Compare
GwnDaan
force-pushed
the
daan/ntcan-driver
branch
from
ae51168 to
db00fa4
Compare
|
ad3154
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Continued #198
I will create another PR in the coming days that adds an example on how to bridge two hardware plugins together. This allows one to use a virtual bus, while connecting it to (multiple) physical busses as well.
How has this been tested?
I have tested it using their virtual can bus and everything is functioning as it should.