Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AgIsoStack #8

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Update AgIsoStack #8

merged 1 commit into from
Feb 10, 2024

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Feb 9, 2024

What's New

-- Updated the version of AgIsoStack++ to 867d2c0d02a31f97c17aab2d17970f650db1bf8e

This update includes months of improvements and new features!

Some features include:

  • Better TP and ETP conformance with ISO11783
  • Language command improvements
  • Added ways to trigger an update of your device descriptor object pool
  • Added ISO11783-11 references
  • Fixed a number of issues with NMEA2000
  • Added a VT client state tracker which can help you develop more advanced VT projects
  • General bug fixes

Visit us on the main repo for more information.

Join us on Discord for support, to share your project, and good vibes in general! Alternatively, you can also join us on Telegram.

Updated the version of AgIsoStack++ to 867d2c0d02a31f97c17aab2d17970f650db1bf8e
@ad3154 ad3154 requested a review from GwnDaan February 9, 2024 02:58
@ad3154 ad3154 self-assigned this Feb 9, 2024
Copy link
Member

@GwnDaan GwnDaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be a bit hesitant about the versioning, since we're introducing a lot of breaking changes but just increasing the patch version (considering semantic versioning). Though I also don't like ending up with different versions for the arduino library and main library... Not sure what's best here

@ad3154
Copy link
Member Author

ad3154 commented Feb 9, 2024

Yeah, I'm really not sure what to do with the version... We broken enough stuff to where increasing the major version probably makes sense, but I don't know if I like "1.0.0" for a project with an unstable API.... I dunno. Ideally it would be nice to sync the two repo's versions

@GwnDaan
Copy link
Member

GwnDaan commented Feb 9, 2024

Yeahh, let's just stick with this for now. Or increase the version to 0.2, idk... I think keeping the major version 0 for now keeps us able to sync it with the main branch

@ad3154
Copy link
Member Author

ad3154 commented Feb 10, 2024

OK... I had picked .4 to realign the arduino version with the git tag version. IDK why they are out of sync...

@ad3154 ad3154 merged commit a2cdca9 into main Feb 10, 2024
2 checks passed
@ad3154 ad3154 deleted the adrian/update branch February 10, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants