Merge pull request #281 from OpShin/fix/enforce_forbidden_overwrite

Add a test case for forbidden overwrites

opshin/rewrite/rewrite_forbidden_overwrites.py

@@ -29,7 +29,7 @@ class RewriteForbiddenOverwrites(CompilingNodeTransformer):
     step = "Checking for forbidden name overwrites"
 
     def visit_Name(self, node: Name) -> Name:
-        if node.ctx == Store() and node.id in FORBIDDEN_NAMES:
+        if isinstance(node.ctx, Store) and node.id in FORBIDDEN_NAMES:
             raise ForbiddenOverwriteError(
                 f"It is not allowed to overwrite name {node.id}"
             )

opshin/tests/test_misc.py

@@ -2160,3 +2160,14 @@ def append_byte_string(x: bytes, y: bytes) -> bytes:
             return x + y
 
         assert append_byte_string(b"hello", b"world") == b"helloworld"
+
+    @unittest.expectedFailure
+    def test_forbidden_overwrite(self):
+        source_code = """
+def validator(
+    d: int
+):
+    PlutusData = d
+    return d
+"""
+        builder._compile(source_code)