Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fixed layout for create chat view and group chat info #978

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Sep 27, 2023

Fixes #

Proposed Changes

@vi-sudo
Copy link

vi-sudo commented Sep 27, 2023

Task linked: OB-6801 GroupInfo layout broken

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@what-the-diff
Copy link

what-the-diff bot commented Sep 27, 2023

PR Summary

  • Enhanced Group Chat Creation UI
    Added new form and div elements with various styling classes to CreateGroupChatView.tsx, which enhances the user interface when creating a group chat.

  • Styling Updates in GroupChatInfo
    Modified various class names in GroupChatInfo.tsx from profile__-based classes to groupChatInfo__-based classes. This results in more meaningful class names that mirror the actual functionality of the elements.

  • New Styling Files
    Created a new SCSS file called groupChatInfo.styles.scss and added styles to an existing file, createChat.styles.scss, to accommodate the new UI enhancements.

  • Optimized Imports
    Simplified and optimized the import of styles inside GroupChatInfo.tsx.

Note: There seems to be a minor mistake - class groupChatInfo was replaced with nonexistent class profile-divider-text-align, which might need a fix.

@web-mi web-mi merged commit 68f346e into develop Sep 27, 2023
8 checks passed
@web-mi web-mi deleted the OB-6801 branch September 27, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants