Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NB-44 iaas.py File Renamed to paas.py #48

Merged
merged 2 commits into from
Jun 17, 2024
Merged

NB-44 iaas.py File Renamed to paas.py #48

merged 2 commits into from
Jun 17, 2024

Conversation

yash-pal1
Copy link
Contributor

@yash-pal1 yash-pal1 commented Jun 13, 2024 •
edited by jira bot
Loading

NetBox Plugin Pull Request

Fixes: NB-44

@yash-pal1 yash-pal1 added the priority: high After critical issues are fixed, these should be dealt with before any further issues. label Jun 13, 2024
@yash-pal1 yash-pal1 requested a review from abhi1693 June 13, 2024 11:52
@yash-pal1 yash-pal1 self-assigned this Jun 13, 2024
abhi1693
abhi1693 requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@abhi1693 abhi1693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class names must also be renamed.

@yash-pal1 yash-pal1 requested a review from abhi1693 June 14, 2024 11:52
@abhi1693 abhi1693 changed the base branch from master to dev June 17, 2024 11:37
@abhi1693 abhi1693 merged commit f9a6d2d into dev Jun 17, 2024
5 checks passed
@abhi1693 abhi1693 deleted the NB-44-rename-file branch June 17, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi1693 abhi1693 abhi1693 approved these changes

Assignees

@yash-pal1 yash-pal1

Labels
priority: high After critical issues are fixed, these should be dealt with before any further issues.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-pal1 @abhi1693