Add utility method to determine aggregation type by monitor metric type

OneUptime · Nov 7, 2024 · f67f1a6 · f67f1a6
1 parent a31ef12
commit f67f1a6
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/Common/Utils/Monitor/MonitorMetricType.ts b/Common/Utils/Monitor/MonitorMetricType.ts
@@ -1,8 +1,34 @@
+import AggregationType from "../../Types/BaseDatabase/AggregationType";
 import { CheckOn } from "../../Types/Monitor/CriteriaFilter";
 import MonitorMetricType from "../../Types/Monitor/MonitorMetricType";
 import MonitorType from "../../Types/Monitor/MonitorType";
 
 class MonitorMetricTypeUtil {
+
+
+  public static getAggregationTypeByMonitorMetricType(
+    monitorMetricType: MonitorMetricType,
+  ): AggregationType { 
+    switch (monitorMetricType) {
+      case MonitorMetricType.ResponseTime:
+        return AggregationType.Avg;
+      case MonitorMetricType.ResponseStatusCode:
+        return AggregationType.Max;
+      case MonitorMetricType.IsOnline:
+        return AggregationType.Min;
+      case MonitorMetricType.DiskUsagePercent:
+        return AggregationType.Max;
+      case MonitorMetricType.CPUUsagePercent:
+        return AggregationType.Avg;
+      case MonitorMetricType.MemoryUsagePercent:
+        return AggregationType.Avg;
+      case MonitorMetricType.ExecutionTime:
+        return AggregationType.Avg;
+      default:
+        throw new Error("Invalid MonitorMetricType value");
+    }
+  }
+
   public static getMonitorMeticTypeByCheckOn(
     checkOn: CheckOn,
   ): MonitorMetricType {

diff --git a/Dashboard/src/Components/Monitor/MonitorMetrics.tsx b/Dashboard/src/Components/Monitor/MonitorMetrics.tsx
@@ -110,7 +110,9 @@ const MonitorMetricsElement: FunctionComponent<ComponentProps> = (
                 monitorId: props.monitorId.toString(),
                 projectId: DashboardNavigation.getProjectId()?.toString() || "",
               },
-              aggegationType: AggregationType.Avg,
+              aggegationType: MonitorMetricTypeUtil.getAggregationTypeByMonitorMetricType(
+                monitorMetricType,
+              ),
             },
           },
         });