conditional compile cleanup leftovers

[424778940z]

Summary by CodeRabbit

Release Notes

• Refactor

  • Simplified bootloader and configuration code by removing model-specific conditional compilation.
  • Streamlined wipe confirmation process across different device models.
  • Reduced complexity in display rendering functions.

• Removed Features

  • Removed several display-related functions including text rendering, image display, and progress indicators.
  • Eliminated model-specific handling for firmware version and boot screen messages.

Note: These changes may impact device-specific functionality and display capabilities.

[coderabbitai]

Walkthrough

The pull request introduces significant code simplification across multiple files in the Trezor firmware. The changes primarily focus on removing conditional compilation related to production models, streamlining display and bootloader functionality. The modifications remove model-specific logic, reducing code complexity and creating a more uniform implementation across different device configurations.

Changes

File	Change Summary
core/embed/bootloader/bootui.c	Removed production model-specific conditional compilation, simplified firmware version and boot screen message handling. Added new header inclusions.
core/embed/bootloader/main.c	Simplified wipe confirmation process, removed model-specific UI handling.
core/embed/extmod/modtrezorconfig/norcow_config.h	Standardized NORCOW_SECTOR_SIZE to a fixed value, removed model-specific sector size definitions.
core/embed/extmod/modtrezorui/display.c	Extensive deletion of display-related functions including color interpolation, coordinate clamping, drawing, and rendering methods.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🔭 Outside diff range comments (1)

core/embed/bootloader/bootui.c (1)

Line range hint 432-486: Add touch input validation.

The ui_input_poll function needs bounds checking for touch coordinates and debouncing for multiple clicks.

🧹 Nitpick comments (1)

core/embed/bootloader/bootui.c (1)

Line range hint 577-589: Fix spelling: "avaliable" → "available"

-                      "avaliable! The current version is", -1, FONT_NORMAL,
+                      "available! The current version is", -1, FONT_NORMAL,

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7265a5c and 0cc65c8.

📒 Files selected for processing (4)

• core/embed/bootloader/bootui.c (1 hunks)
• core/embed/bootloader/main.c (0 hunks)
• core/embed/extmod/modtrezorconfig/norcow_config.h (0 hunks)
• core/embed/extmod/modtrezorui/display.c (0 hunks)

💤 Files with no reviewable changes (3)

• core/embed/extmod/modtrezorconfig/norcow_config.h
• core/embed/bootloader/main.c
• core/embed/extmod/modtrezorui/display.c

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Gen check
• GitHub Check: Defs check
• GitHub Check: Style check

🔇 Additional comments (2)

core/embed/bootloader/bootui.c (2)

44-49: LGTM! Header includes are well-organized.

---

Line range hint 102-111: Add version component validation.

The format_ver function should validate version components before formatting.