Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support aptos signAndSubmitTransaction #261

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

ByteZhang1024
Copy link
Contributor

@ByteZhang1024 ByteZhang1024 commented Dec 5, 2024

Summary by CodeRabbit

发布说明

  • 新特性

    • 增加了对 Aptos 钱包的交易签名和提交功能,支持正常和编码参数的测试。
  • 版本更新

    • 所有相关包的版本已从 2.1.19 更新至 2.1.20,包括:
      • @onekeyfe/cross-inpage-provider-core
      • @onekeyfe/cross-inpage-provider-errors
      • @onekeyfe/cross-inpage-provider-types
      • 以及多个提供者包。

Copy link

coderabbitai bot commented Dec 5, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

本次更改主要涉及多个包的 package.json 文件更新,版本号均从 2.1.19 增加到 2.1.20。同时,相关依赖项的版本也进行了相应更新,确保所有相关包保持一致。更改涵盖了多个包,包括核心提供者、错误处理、事件处理等,确保系统整体的一致性和稳定性。此外,部分文件中还增加了新的功能和方法,以增强交易处理能力。

Changes

文件路径 更改摘要
packages/core/package.json 版本更新至 2.1.20,依赖项 @onekeyfe/cross-inpage-provider-errors@onekeyfe/cross-inpage-provider-events@onekeyfe/cross-inpage-provider-types 更新至 2.1.20
packages/core/src/versionInfo.ts 版本常量更新至 '2.1.19'
packages/desktop/desktop-bridge-injected/package.json 版本更新至 2.1.20,依赖项 @onekeyfe/cross-inpage-provider-core@onekeyfe/cross-inpage-provider-types 更新至 2.1.20
packages/empty/package.json 版本更新至 2.1.20
packages/errors/package.json 版本更新至 2.1.20
packages/events/package.json 版本更新至 2.1.20
packages/example/components/chains/aptosStandard/example.tsx 新增 signAndSubmitTransaction Normal ArgumentsignAndSubmitTransaction Encode Argument 方法。
packages/example/package.json 版本更新至 2.1.20,多个依赖项更新至 2.1.20
packages/extension/extension-bridge-hosted/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/extension/extension-bridge-injected/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/injected/package.json 版本更新至 2.1.20,多个依赖项更新至 2.1.20
packages/native/native-bridge-injected/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/inpage-providers-hub/package.json 版本更新至 2.1.20,多个依赖项更新至 2.1.20
packages/providers/onekey-algo-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-alph-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-aptos-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-aptos-provider/src/OnekeyAptosProvider.ts 新增 signAndSubmitTransactionV2 方法,更新 signAndSubmitTransaction 方法实现。
packages/providers/onekey-aptos-provider/src/StandardProvider.ts 新增 signAndSubmitTransaction 方法,更新 features 获取器。
packages/providers/onekey-bfc-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-btc-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-cardano-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-conflux-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-cosmos-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-cosmos-provider/src/OnekeyCosmosProvider.ts 更新 signDirect 方法签名,增加钱包事件处理功能。
packages/providers/onekey-eth-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-near-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-nostr-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-polkadot-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-private-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-scdo-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-solana-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-sui-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-ton-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-tron-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/providers/onekey-webln-provider/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20
packages/types/package.json 版本更新至 2.1.20
packages/webview/package.json 版本更新至 2.1.20,依赖项更新至 2.1.20

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 7428b11 and b654b89.

📒 Files selected for processing (37)
  • packages/core/package.json (2 hunks)
  • packages/core/src/versionInfo.ts (1 hunks)
  • packages/desktop/desktop-bridge-injected/package.json (2 hunks)
  • packages/empty/package.json (1 hunks)
  • packages/errors/package.json (1 hunks)
  • packages/events/package.json (1 hunks)
  • packages/example/components/chains/aptosStandard/example.tsx (3 hunks)
  • packages/example/package.json (2 hunks)
  • packages/extension/extension-bridge-hosted/package.json (2 hunks)
  • packages/extension/extension-bridge-injected/package.json (2 hunks)
  • packages/injected/package.json (2 hunks)
  • packages/native/native-bridge-injected/package.json (2 hunks)
  • packages/providers/inpage-providers-hub/package.json (2 hunks)
  • packages/providers/onekey-algo-provider/package.json (2 hunks)
  • packages/providers/onekey-alph-provider/package.json (2 hunks)
  • packages/providers/onekey-aptos-provider/package.json (2 hunks)
  • packages/providers/onekey-aptos-provider/src/OnekeyAptosProvider.ts (5 hunks)
  • packages/providers/onekey-aptos-provider/src/StandardProvider.ts (4 hunks)
  • packages/providers/onekey-bfc-provider/package.json (2 hunks)
  • packages/providers/onekey-btc-provider/package.json (2 hunks)
  • packages/providers/onekey-cardano-provider/package.json (2 hunks)
  • packages/providers/onekey-conflux-provider/package.json (2 hunks)
  • packages/providers/onekey-cosmos-provider/package.json (2 hunks)
  • packages/providers/onekey-cosmos-provider/src/OnekeyCosmosProvider.ts (2 hunks)
  • packages/providers/onekey-eth-provider/package.json (2 hunks)
  • packages/providers/onekey-near-provider/package.json (2 hunks)
  • packages/providers/onekey-nostr-provider/package.json (2 hunks)
  • packages/providers/onekey-polkadot-provider/package.json (2 hunks)
  • packages/providers/onekey-private-provider/package.json (2 hunks)
  • packages/providers/onekey-scdo-provider/package.json (2 hunks)
  • packages/providers/onekey-solana-provider/package.json (2 hunks)
  • packages/providers/onekey-sui-provider/package.json (2 hunks)
  • packages/providers/onekey-ton-provider/package.json (2 hunks)
  • packages/providers/onekey-tron-provider/package.json (2 hunks)
  • packages/providers/onekey-webln-provider/package.json (2 hunks)
  • packages/types/package.json (1 hunks)
  • packages/webview/package.json (2 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Report too large to display inline

View full report↗︎

@ByteZhang1024 ByteZhang1024 merged commit 2f131db into master Dec 5, 2024
5 of 7 checks passed
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Possible typosquat attack npm/[email protected] ⚠︎
Protestware or potentially unwanted behavior npm/[email protected]
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
⚠︎
Possible typosquat attack npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@ByteZhang1024 ByteZhang1024 deleted the feat/aptosSignAndSubmitTransaction branch December 5, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants