Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/arrival-departure-update #154

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix/arrival-departure-update #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4438d9f
refactor: wrap arrivals and departures in a key block for updates
Ahmedhossamdev Dec 2, 2024
88c37c7
refactor: increase z-index of LoadingSpinner for improved overlay vis…
Ahmedhossamdev Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/LoadingSpinner.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
</script>

<div
class="absolute inset-0 z-10 flex items-center justify-center bg-neutral-800 bg-opacity-80 md:rounded-lg"
class="absolute inset-0 z-50 flex items-center justify-center bg-neutral-800 bg-opacity-80 md:rounded-lg"
>
<div class="flex items-center text-white">
<svg
Expand Down
30 changes: 18 additions & 12 deletions src/components/stops/StopPane.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,18 +119,24 @@
<p>{$t('no_arrivals_or_departures_in_next_30_minutes')}</p>
</div>
{:else}
<Accordion {handleAccordionSelectionChanged}>
{#each arrivalsAndDepartures.arrivalsAndDepartures as arrival}
<AccordionItem data={arrival}>
{#snippet header()}
<span>
<ArrivalDeparture arrivalDeparture={arrival} />
</span>
{/snippet}
<TripDetailsPane {stop} tripId={arrival.tripId} serviceDate={arrival.serviceDate} />
</AccordionItem>
{/each}
</Accordion>
{#key arrivalsAndDepartures.arrivalsAndDepartures}
<Accordion {handleAccordionSelectionChanged}>
{#each arrivalsAndDepartures.arrivalsAndDepartures as arrival}
<AccordionItem data={arrival}>
{#snippet header()}
<span>
<ArrivalDeparture arrivalDeparture={arrival} />
</span>
{/snippet}
<TripDetailsPane
{stop}
tripId={arrival.tripId}
serviceDate={arrival.serviceDate}
/>
</AccordionItem>
{/each}
</Accordion>
{/key}
{/if}
</div>
{/if}
Expand Down
Loading