Feature/schedule-visualization #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heduleAccordionItem
…alize with current date
… conditional rendering for AM/PM availability
aaronbrethorst
requested changes
Nov 22, 2024
There was a problem hiding this comment.
This is looking great! I have noted a couple minor changes to make before merging. Also, now that I see this schedule page with its "Show real time information" button, it feels clear to me that these should be unified in some way. I'll open a new task for that. Bravo!
| @@ -14,13 +15,6 @@ | |||
| let interval; | |||
| let busPosition = 0; | |||
|
|
|||
| function formatTime(seconds) { | |||
| schedulesMap.clear(); | ||
| routeReference.clear(); | ||
|
|
||
| if (!scheduleForStop.entry.stopRouteSchedules.length) { |
| @@ -38,7 +38,7 @@ | |||
| }; | |||
| } else if (scheduledDiff <= 0) { | |||
| return { | |||
| status: 'on time', | |||
| status: `${$t('status.on_time')}`, | |||
There was a problem hiding this comment.
I'll still merge this, but is there any reason this isn't expressed as:
status: $t('status.on_time'),
isn't the outer template string redundant?
There was a problem hiding this comment.
you're right I will update it in the upcoming PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #123