Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Credits Dark Mode Issues and refactor webview code #721

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Fix Credits Dark Mode Issues and refactor webview code #721

merged 1 commit into from
Apr 5, 2024

Conversation

hilmyveradin
Copy link
Collaborator

To fix this issue:

#720

I created this PR with this result:

Simulator Screen Recording - iPhone 15 Pro - 2024-03-26 at 22 02 10

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aaronbrethorst
aaronbrethorst requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just one stylistic change and it'll be ready for merge, I think.

OBAKit/WebView/DocumentWebView.swift Outdated Show resolved Hide resolved
aaronbrethorst
aaronbrethorst requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good. please squash the three commits into a single one.

@hilmyveradin hilmyveradin force-pushed the issue_720_credits-dark-mode branch from 1671cb0 to a1e0770 Compare March 28, 2024 11:59
@hilmyveradin hilmyveradin changed the title Fix Dark Credits Dark Mode Issues and refactor webview code Fix Credits Dark Mode Issues and refactor webview code Apr 1, 2024
aaronbrethorst
aaronbrethorst approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronbrethorst aaronbrethorst merged commit e8eb008 into OneBusAway:main Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hilmyveradin @CLAassistant @aaronbrethorst