Merge pull request #2621 from OmniSharp/update-sdks-2

Update .NET SDKs

.github/workflows/build.yml

@@ -1,9 +1,9 @@
 
 name: 'Build'
 env:
-  DotNetVersion: "9.0.100-preview.1.24101.2"
-  DotNetVersion2: "8.0.201"
-  DotNetVersion3: "7.0.406"
+  DotNetVersion: "9.0.100-preview.6.24328.19"
+  DotNetVersion2: "8.0.303"
+  DotNetVersion3: "7.0.410"
   DotNetVersion4: "6.0.203" # This is the last version Mono supports. It is used for our Mono CI tests.
   NuGetVersion: "6.5.0"
   MonoVersion: "6.12.0"

.github/workflows/tests-net6.yml

@@ -1,9 +1,9 @@
 
 name: 'Tests net6.0'
 env:
-  DotNetVersion: "9.0.100-preview.1.24101.2"
-  DotNetVersion2: "8.0.201"
-  DotNetVersion3: "7.0.406"
+  DotNetVersion: "9.0.100-preview.6.24328.19"
+  DotNetVersion2: "8.0.303"
+  DotNetVersion3: "7.0.410"
   DotNetVersion4: "6.0.203" # This is the last version Mono supports. It is used for our Mono CI tests.
   NuGetVersion: "6.5.0"
   MonoVersion: "6.12.0"

.github/workflows/tests.yml

@@ -1,9 +1,9 @@
 
 name: 'Tests'
 env:
-  DotNetVersion: "9.0.100-preview.1.24101.2"
-  DotNetVersion2: "8.0.201"
-  DotNetVersion3: "7.0.406"
+  DotNetVersion: "9.0.100-preview.6.24328.19"
+  DotNetVersion2: "8.0.303"
+  DotNetVersion3: "7.0.410"
   DotNetVersion4: "6.0.203" # This is the last version Mono supports. It is used for our Mono CI tests.
   NuGetVersion: "6.5.0"
   MonoVersion: "6.12.0"

CHANGELOG.md

@@ -1,8 +1,14 @@
 # Changelog
 All changes to the project will be documented in this file.
 
-## [1.39.12] - Not Released
-* Update SDKs and Roslyn ([#2603](https://github.com/OmniSharp/omnisharp-roslyn/pull/2603))
+## [1.39.12] - 2024-07-26
+* Update .NET SDKs (PR: [#2621](https://github.com/OmniSharp/omnisharp-roslyn/pull/2621))
+* Update Roslyn to 4.12.0-1.24358.3 (PR: [#2619](https://github.com/OmniSharp/omnisharp-roslyn/pull/2619))
+* Fix code fix construction (PR: [#2620](https://github.com/OmniSharp/omnisharp-roslyn/pull/2620))
+* Remove NuGet.Packaging.Core, as it's an assembly that only contains forwarders  (PR: [#2610](https://github.com/OmniSharp/omnisharp-roslyn/pull/2610))
+* Fix inlay hints lambdas parameter type null reference exception (PR: [#2604](https://github.com/OmniSharp/omnisharp-roslyn/pull/2604))
+* Update SDKs and Roslyn (PR: [#2603](https://github.com/OmniSharp/omnisharp-roslyn/pull/2603))
+* Pass project path when performing a restore (PR: [#2593](https://github.com/OmniSharp/omnisharp-roslyn/pull/2593))
 
 ## [1.39.11] - 2023-12-19
 * Update changelog (PR: [#2591](https://github.com/OmniSharp/omnisharp-roslyn/pull/2591))

azure-pipelines.yml

@@ -32,7 +32,7 @@ resources:
 
 variables:
   Verbosity: Diagnostic
-  DotNetVersion: "8.0.201"
+  DotNetVersion: "8.0.303"
   CakeVersion: "3.0.0"
   NuGetVersion: "6.5.0"
   GitVersionVersion: "5.0.1"

build.json

@@ -3,9 +3,9 @@
     "DotNetChannel": "Preview",
     "DotNetVersions": [
         "6.0.203",
-        "7.0.406",
-        "8.0.201",
-        "9.0.100-preview.1.24101.2"
+        "7.0.410",
+        "8.0.303",
+        "9.0.100-preview.6.24328.19"
     ],
     "RequiredMonoVersion": "6.6.0",
     "DownloadURL": "https://roslynomnisharp.blob.core.windows.net/ext",

global.json

@@ -1,6 +1,6 @@
 {
     "sdk": {
-        "version": "8.0.201",
+        "version": "8.0.303",
         "rollForward": "latestMinor"
     }
 }

test-assets/test-projects/Net70Project/global.json

@@ -1,5 +1,5 @@
 {
     "sdk": {
-        "version": "7.0.406"
+        "version": "7.0.410"
     }
-}
+}

test-assets/test-projects/Net80Project/global.json

@@ -1,5 +1,5 @@
 {
     "sdk": {
-        "version": "8.0.201"
+        "version": "8.0.303"
     }
 }

test-assets/test-projects/Net90Project/global.json

@@ -1,5 +1,5 @@
 {
     "sdk": {
-        "version": "9.0.100-preview.1.24101.2"
+        "version": "9.0.100-preview.6.24328.19"
     }
 }

tests/OmniSharp.MSBuild.Tests/ProjectLoadListenerTests.cs

@@ -231,7 +231,7 @@ public async Task The_correct_sdk_version_is_emitted_NET7()
             using var testProject = await TestAssets.Instance.GetTestProjectAsync("Net70Project");
             using var host = CreateMSBuildTestHost(testProject.Directory, emitter.AsExportDescriptionProvider(LoggerFactory));
             Assert.Single(emitter.ReceivedMessages);
-            Assert.Equal(GetHashedFileExtension("7.0.406"), emitter.ReceivedMessages[0].SdkVersion);
+            Assert.Equal(GetHashedFileExtension("7.0.410"), emitter.ReceivedMessages[0].SdkVersion);
         }
 
         [ConditionalFact(typeof(DotnetRuntimeOnly))]
@@ -243,7 +243,7 @@ public async Task The_correct_sdk_version_is_emitted_NET8()
             using var testProject = await TestAssets.Instance.GetTestProjectAsync("Net80Project");
             using var host = CreateMSBuildTestHost(testProject.Directory, emitter.AsExportDescriptionProvider(LoggerFactory));
             Assert.Single(emitter.ReceivedMessages);
-            Assert.Equal(GetHashedFileExtension("8.0.201"), emitter.ReceivedMessages[0].SdkVersion);
+            Assert.Equal(GetHashedFileExtension("8.0.303"), emitter.ReceivedMessages[0].SdkVersion);
         }
 
         [ConditionalFact(typeof(DotnetRuntimeOnly))]
@@ -255,7 +255,7 @@ public async Task The_correct_sdk_version_is_emitted_NET9()
             using var testProject = await TestAssets.Instance.GetTestProjectAsync("Net90Project");
             using var host = CreateMSBuildTestHost(testProject.Directory, emitter.AsExportDescriptionProvider(LoggerFactory));
             Assert.Single(emitter.ReceivedMessages);
-            Assert.Equal(GetHashedFileExtension("9.0.100-preview.1.24101.2"), emitter.ReceivedMessages[0].SdkVersion);
+            Assert.Equal(GetHashedFileExtension("9.0.100-preview.6.24328.19"), emitter.ReceivedMessages[0].SdkVersion);
         }
 
         private string GetHashedFileExtension(string fileExtension)

tests/OmniSharp.Roslyn.CSharp.Tests/QuickInfoProviderFacts.cs

@@ -196,7 +196,7 @@ public async Task DisplayFormatForMethodSymbol_Invocation()
             var response = await GetTypeLookUpResponse(line: 6, column: 35);
 
 #if NETCOREAPP
-            Assert.Equal("```csharp\nvoid Console.WriteLine(string? value) (+ 17 overloads)\n```", response.Markdown);
+            Assert.Equal("```csharp\nvoid Console.WriteLine(string? value) (+ 18 overloads)\n```", response.Markdown);
 #else
             Assert.Equal("```csharp\nvoid Console.WriteLine(string value) (+ 18 overloads)\n```", response.Markdown);
 #endif

tests/OmniSharp.Tests/DotNetCliServiceFacts.cs

@@ -7,7 +7,7 @@ namespace OmniSharp.Tests
 {
     public class DotNetCliServiceFacts : AbstractTestFixture
     {
-        private const string DotNetVersion = "8.0.201";
+        private const string DotNetVersion = "8.0.303";
         private int Major { get; }
         private int Minor { get; }
         private int Patch { get; }