Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.7.7a peptide parameters #97

Open
wants to merge 5 commits into
base: 4.7.7a
Choose a base branch
from
Open

Conversation

Heriette
Copy link
Member

No description provided.

Copy link
Member

@weiclav weiclav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would adjust the joiner node to keep the row keys and not to process it in case of duplicity in the column names would be found in the original table and the table with the calculated features

PTMs should be spelled out

the Peptides R packjage should be mentioned in the description including the accompanied license

and there is not properly handled the case when there are not valid aminoacid characters, it calculates the values despite that and returns no error, check the check routine please - I would return the sequences where there were some not expected characters as a separate table output, where there would be only the sequence column selected by the user and the calculated features columns...

@Heriette
Copy link
Member Author

Hi, please ignore the last commit

@Heriette
Copy link
Member Author

Hi @weiclav I found one more error with some internal column selection (strings with special characters), but it should be ok now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants