Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move component library into project #2834

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

brightiron
Copy link
Contributor

@brightiron brightiron commented May 21, 2023

Remove the dependency on the external @olympusdao/component-library package. This is the only project this is now used on, so consolidating it into this project makes maintenance a bit easier.

  • Also add storybook as a dev dependency to make local dev easier.
  • Add previously used storybook stories for local dev.

also resolves #2772

@socket-security
Copy link

socket-security bot commented May 21, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@brightiron brightiron requested a review from appleseed-iii May 21, 2023 23:44
@0xJem
Copy link
Contributor

0xJem commented Jul 25, 2023

@appleseed-iii @brightiron can you guys complete this PR? It would be good to have the component errors fixed.

@0xJem
Copy link
Contributor

0xJem commented Sep 28, 2023

Any plans to go through with this?

@brightiron
Copy link
Contributor Author

Any plans to go through with this?

yes, for sure. i'm reworking this PR actually. i think it's better we move the repo to a monorepo and just import component library from there. It'll keep things a little cleaner and more easily maintainable .

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricCollection returns error with children
2 participants