-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefine galleryApi endpoint by introducing library for SignalR testing #107
Open
JanSafronov
wants to merge
43
commits into
Olszewskidev:main
Choose a base branch
from
JanSafronov:feature-1.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge recent commits
Merge recent commits
Merge changes
Merge changes from author
Merge changes from author
Feature 1.1 merge
Feature 1.1 merge
…lszewskidev-main
Merge changes from author
Merge recent changes from author
…lszewskidev-main
…gnalR hub mocking
@Olszewskidev This allow to run integration tests for UI packages when hub connection is needed.. |
JanSafronov
changed the title
Redefine galleryApi endpoint by introducing library for testing
Redefine galleryApi endpoint by introducing library for SignalR testing
Jun 4, 2024
Thanks for your changes and adjustments. LensUp takes part in 100 Commits challange (Polish competitions) - https://100commitow.pl/ I will check your PR's after this challange (we are at the end) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefine getGalleryPhotos endpoint of galleryApi by coalescing HubConnectionBuilder and useCypressSignalRMock (They build a hub connection) from Cypress testing library.
Whenever in testing mode, useCypressSignalRMock will not be null and hence a mocked SignalR hub will be instantiated for testing purposes.
Implicity this is coded as
This inherits/includes feature 1 branch given in #87