Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issue-type: both #20

Merged
merged 3 commits into from
Sep 25, 2023
Merged

feat: issue-type: both #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b880425
update: both
Okabe-Junya Sep 25, 2023
0cbe9ff
feat: can choose both
Okabe-Junya Sep 25, 2023
e5e7f69
Merge branch 'main' into junya/feat/issue-type-both
Okabe-Junya Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ inputs:
github-token:
description: 'token for github'
default: ${{ github.server_url == 'https://github.com' && github.token || '' }}
issue-type:
description: 'validate for issue or pull request. if you want to validate pull request, you must set issue-type: "pull_request". Both issue and pull request are validated, if you set issue-type: "both". default is "issue"'
required: false
default: 'issue'
is-auto-close:
description: 'auto close issue if it does not meet the conditions'
required: false
Expand Down
4 changes: 2 additions & 2 deletions src/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export async function validateIssueTitleAndBody(
if (!titleRegex && !bodyRegex) {
return true;
}
if (issueType === 'issue') {
if (issueType === 'issue' || issueType === 'both') {
const { title, body } = await getIssueTitleAndBody(issueNumber);
if (titleRegex && !validate(titleRegex, title)) {
return false;
Expand All @@ -19,7 +19,7 @@ export async function validateIssueTitleAndBody(
}
return true;
}
if (issueType === 'pull_request') {
if (issueType === 'pull_request' || issueType === 'both') {
const { title, body } = await getPullRequestTitleAndBody(issueNumber);
if (titleRegex && !validate(titleRegex, title)) {
return false;
Expand Down