Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos #316

Merged
merged 4 commits into from
Oct 19, 2023
Merged

fix: typos #316

merged 4 commits into from
Oct 19, 2023

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Aug 9, 2023

fix: typos

@cla-bot
Copy link

cla-bot bot commented Aug 9, 2023

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

brtkx
brtkx reviewed Aug 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@cla-bot
Copy link

cla-bot bot commented Aug 17, 2023

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

@omahs
Copy link
Contributor Author

omahs commented Aug 17, 2023

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Aug 17, 2023

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

@cla-bot
Copy link

cla-bot bot commented Aug 17, 2023

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Oct 13, 2023
fionnachan
fionnachan approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@fionnachan fionnachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@fionnachan
Copy link
Member

By the way, @omahs have you signed the CLA?

@omahs
Copy link
Contributor Author

omahs commented Oct 13, 2023

Hey @fionnachan yup I signed it when I opened the PR

@spsjvc spsjvc merged commit 1cc67ee into OffchainLabs:main Oct 19, 2023
douglance added a commit that referenced this pull request Nov 20, 2023
@douglance @omahs
@fionnachan @brtkx @spsjvc
Updates v4 with the latest on main (#376)
4593ce8 
* fix: typos (#316)

Co-authored-by: Fionna Chan <[email protected]>

* fix: default block to 0 if no NodeCreated events found (#371)

* chore: bump version to 3.1.13 (#372)

* chore: update advisories allowlist (#373)

---------

Co-authored-by: omahs <[email protected]>
Co-authored-by: Fionna Chan <[email protected]>
Co-authored-by: Bartek <[email protected]>
Co-authored-by: spsjvc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brtkx brtkx brtkx approved these changes

@fionnachan fionnachan fionnachan approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omahs @fionnachan @brtkx @spsjvc