-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dac documentation #882
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
In review |
arbitrum-docs/node-running/how-tos/data-availability-committee/introduction.mdx
Outdated
Show resolved
Hide resolved
...m-docs/node-running/how-tos/data-availability-committee/partials/_1-how-das-work-content.mdx
Outdated
Show resolved
Hide resolved
...g/how-tos/data-availability-committee/partials/_2.1-das-configuration-options-interfaces.mdx
Outdated
Show resolved
Hide resolved
...g/how-tos/data-availability-committee/partials/_2.1-das-configuration-options-interfaces.mdx
Outdated
Show resolved
Hide resolved
...ning/how-tos/data-availability-committee/partials/_2.2-das-configuration-options-storage.mdx
Outdated
Show resolved
Hide resolved
Thanks @Tristan-Wilson !
Note: I've kept the partial views for now, until everything is good. Will remove those before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a beast of a PR... lots of misc nits, no blocking feedback. TYVM 🙏
title: 'How to configure a Data Availability Committee: configure the DAC in your chain' | ||
description: This how-to will help you configure the DAC in your chain. | ||
author: jose-franco | ||
sidebar_label: Configure the DAC in your chain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sidebar_label: Configure the DAC in your chain | |
sidebar_label: Configure a Data Availability Committee (DAC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the sidebar to "How to configure the Data Availability Committee (DAC) in your chain" since this document is specific about one step of the process and having the same title as the section might be confusing for users. I kept the suggested convention.
arbitrum-docs/node-running/how-tos/data-availability-committee/deploy-a-das.mdx
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,12 @@ | |||
--- | |||
title: 'How to configure a Data Availability Committee: configure the DAC in your chain' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: 'How to configure a Data Availability Committee: configure the DAC in your chain' | |
title: 'How to configure a Data Availability Committee (DAC)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the title too, as specified here.
This PR updates the documentation available to configure a DAC.
Important notes:
tabgroups
without a "label".Preview