Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary updates: stylus things, parent/child chain nomenclature #505

Merged
merged 7 commits into from
Sep 1, 2023

Conversation

DZGoldman
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview Sep 1, 2023 2:32pm

Copy link
Contributor

@TucksonDev TucksonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only flagging that "Parent chain" and "Child chain" are mostly written with the first letter in uppercase. Should we write them in lowercase?

@DZGoldman
Copy link
Contributor Author

@TucksonDev I don't see a way in notion to modify the display text in a glossary link ref (tho maybe I'm missing it?)

@TucksonDev
Copy link
Contributor

Oh, that's right 🤔 . Let's leave it like that then. If we find a good way to change the rendering in the notion lib, we can do that later (might be a bit tricky though).
Thanks!

@symbolpunk symbolpunk merged commit 12a0599 into master Sep 1, 2023
2 checks passed
@symbolpunk symbolpunk deleted the glossary-updates branch September 1, 2023 14:34
@symbolpunk
Copy link
Contributor

TYSM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants