Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion of the [wght].ttf variable font #11

Merged
merged 38 commits into from
Oct 15, 2020

Conversation

pichotta
Copy link
Contributor

@meirsadan
@OdedEzer
The weight axis variable font for Heebo is complete. Will you accept this pull request to merge the [wght].ttf and the .ufo sources into the master?

@OdedEzer
Copy link
Owner

OdedEzer commented Oct 15, 2020 via email

@meirsadan
Copy link
Collaborator

Hi,
@OdedEzer I've reviewed the binary files and found the sheqel symbol is indeed defined at code point 20AA in the binary font files. Are there any other issues?
@pichotta Can you confirm it exists within your source files? It's been a longstanding bug in the current font offered at the main Google Fonts site
Thanks,
Meir

@pichotta
Copy link
Contributor Author

@meirsadan
@OdedEzer
The /shequel is present both in the source and in the variable font.

Heebo sheqel 2020-10-15 at 3 36 49 PM

Heebo sheqel  2020-10-15 at 3 41 40 PM

@OdedEzer
Copy link
Owner

OdedEzer commented Oct 15, 2020 via email

@meirsadan
Copy link
Collaborator

No more issues from me, going to merge this request now.
Thanks all

@meirsadan meirsadan merged commit 8f70922 into OdedEzer:master Oct 15, 2020
@OdedEzer
Copy link
Owner

OdedEzer commented Oct 15, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants