This repository has been archived by the owner on May 2, 2023. It is now read-only.
Fix HealthCheck auth endpoint for alternate Azure Clouds (Server 2022.1 stream) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imi.AzureAppService' project: VCS roots of 'Chain: Build and Test and Publish to Feedz.io' build configuration were updated
…imi.AzureAppService' project: VCS roots of 'Chain: Build and Test and Publish to Feedz.io' build configuration were updated
…imi.AzureAppService' project: build features of 'Chain: Build and Test and Publish to Feedz.io' build configuration were updated
…imi.AzureAppService' project: triggers of 'Chain: Build and Test and Publish to Feedz.io' build configuration were updated
…imi.AzureAppService' project: 'Chain: Build and Test and Publish to Feedz.io' build configuration settings were updated
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: snapshot dependency was added in 'Chain: Build and Test and Publish to Feedz.io' build configuration
…imi.AzureAppService' project: general settings of 'Chain: Build and Test and Publish to Feedz.io' build configuration were updated
…imi.AzureAppService' project: project 'Build: Test Images' was created
…shimiAzureAppService_BuildTestImages: project 'Build: Test Images' was removed
…tings (#35) * Ensure HealthCheck respects configured proxy settings * Extract integration test base class to its own file * Pull common variable setup down to base class * Add test to ensure Health Check respects proxy settings * Ensure Proxy test works on both CI and locally * Fixes another small difference in testing between CI and local * More tweaks to test for cross-OS assertion * Fix up refactor in AppServiceBehaviourFixture * Simplify Proxy test code
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 747366 | Generic High Entropy Secret | 3d4d008 | source/Spike/Spike/Program.cs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Ew. What happened with this branch. Let's not. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We recently fixed a problem where the configured proxy was not respected when performing Azure App Service target health checks. This involved using a new version of the Azure SDK, because the previous version was causing the bug and Microsoft will not fix it.
In doing so, we introduced OctopusDeploy/Issues#7663, which causes health-checks on Azure Clouds other than Azure Public Cloud to fail. This is because the AuthorityHost for the login process had not been correctly plumbed through to the new SDK client, and it's very hard for people outside those Azure Cloud regions to get access to test against them.
Result
This PR ensures that the AuthorityHost is correctly plumbed through to the SDK Client for the login process, which when adopted into Octopus Server will remediate OctopusDeploy/Issues#7663