This repository has been archived by the owner on May 2, 2023. It is now read-only.
Fix HealthCheck auth endpoint for alternate Azure Clouds #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jul 19, 2022
Co-authored-by: Yihao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We recently fixed a problem where the configured proxy was not respected when performing Azure App Service target health checks. This involved using a new version of the Azure SDK, because the previous version was causing the bug and Microsoft will not fix it.
In doing so, we introduced OctopusDeploy/Issues#7663, which causes health-checks on Azure Clouds other than Azure Public Cloud to fail. This is because the AuthorityHost for the login process had not been correctly plumbed through to the new SDK client, and it's very hard for people outside those Azure Cloud regions to get access to test against them.
Result
This PR ensures that the AuthorityHost is correctly plumbed through to the SDK Client for the login process, which when adopted into Octopus Server will remediate OctopusDeploy/Issues#7663