Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use v1.8.0 in cluster creation #32

Merged
merged 22 commits into from
Jul 2, 2024
Merged

use v1.8.0 in cluster creation #32

merged 22 commits into from
Jul 2, 2024

Conversation

HananINouman
Copy link
Collaborator

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
31.5% Duplication on New Code (required ≤ 30%)

See analysis details on SonarCloud

@HananINouman HananINouman changed the base branch from Hanan/v1.8.0 to main May 2, 2024 16:31
@HananINouman HananINouman marked this pull request as ready for review May 2, 2024 16:31
@HananINouman HananINouman requested a review from a team as a code owner May 2, 2024 16:31
LukeHackett12
LukeHackett12 approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@LukeHackett12 LukeHackett12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! small comments

src/verification/v1.6.0.ts Outdated Show resolved Hide resolved
src/verification/common.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
14.6% Duplication on New Code

See analysis details on SonarCloud

LukeHackett12
LukeHackett12 approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@LukeHackett12 LukeHackett12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/ajv.ts Show resolved Hide resolved
LukeHackett12
LukeHackett12 approved these changes Jul 2, 2024
View reviewed changes
src/ajv.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
15.3% Duplication on New Code

See analysis details on SonarCloud

@HananINouman HananINouman merged commit 1169e42 into main Jul 2, 2024
2 checks passed
@HananINouman HananINouman deleted the Hanan/default-v1.8.0 branch July 2, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeHackett12 LukeHackett12 LukeHackett12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HananINouman @LukeHackett12