Extend example to show embedded Xtext editor for transitions. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Obeo, Can you please provide feedback on this pull request. I think it would help anyone that would want to embed Xtext editors within Sirius based graphical modelers. Kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Obeo,
The example only worked for nodes on the diagram. So I spend some time to extendthe example to enable showing the editor for edges as well. To do this, I had to find the ConnectionEditPart given the semantic element passed from the Sirius diagram. I can imagine the way I did it can be more efficient, so feedback is desired.
Kind regards,
Niels Brouwers.