Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Module Migration Feature #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nitinsinghoxidesales
Copy link
Contributor

Implemented Module Migration Feature

Note: Currently we are implementing this feature with PS oxid-console module and later we will merge this feature with core console module.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/Command/MigrateCommand.php Outdated Show resolved Hide resolved
src/Core/Migration/MigrationHandler.php Outdated Show resolved Hide resolved
src/Core/Migration/MigrationHandler.php Outdated Show resolved Hide resolved
src/Core/Migration/MigrationHandler.php Outdated Show resolved Hide resolved
src/Core/Migration/MigrationHandler.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@alfredbez alfredbez linked an issue Feb 18, 2020 that may be closed by this pull request
@alfredbez
Copy link
Contributor

alfredbez commented Feb 18, 2020

The following things should be tested in CI:

  • still runs migrations from the project only
  • runs migrations from active modules
  • does not run migrations from inactive modules
  • runs migrations from the project and from modules in a single run
  • does not run migrations from active modules if --skip-module-migration is set
  • works with OXID 6.1
  • works with OXID 6.2

@nitinsinghoxidesales
Copy link
Contributor Author

All the check points been tested on my local system and its working for me. I just have to test whether it works with OXID 6.1 or not.

@alfredbez
Copy link
Contributor

I'd like to have these checks in a CI system like Github Actions.

@nitinsinghoxidesales
Copy link
Contributor Author

Sure, i will add all these checks with github checkpoints.

@alfredbez
Copy link
Contributor

It would also be helpful if we display the migration-directories in the output, e.g.:

Running migration scripts
adding migrations from <module-id1 / module-path1>
adding migrations from <module-id2 / module-path2>
Migration finished successfully

@keywan-ghadami
Copy link

related work from the oxid core team: OXID-eSales/oxideshop-facts@383a33c

@nitinsinghoxidesales
Copy link
Contributor Author

@keywan-ghadami
FYI - Seems there is an error with recent changes in OXID-eSales/oxideshop-facts@383a33c package.

Here is my comment.
OXID-eSales/oxideshop-facts@383a33c#r39852749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to handle migrations in modules
3 participants