OXDEV-8462 Clean up

OXID-eSales · Jul 15, 2024 · 81522ca · 81522ca
1 parent fc9523c
commit 81522ca
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 11 deletions.
diff --git a/services.yaml b/services.yaml
@@ -9,8 +9,6 @@ services:
   _defaults:
     public: false
     autowire: true
-    bind:
-      OxidEsales\Eshop\Core\Request: '@=service("OxidEsales\\ModuleTemplate\\Core\\Registry").getRequest()'
 
   OxidEsales\ModuleTemplate\Core\Registry:
     class: OxidEsales\Eshop\Core\Registry

diff --git a/tests/Integration/Controller/Admin/GreetingAdminControllerTest.php b/tests/Integration/Controller/Admin/GreetingAdminControllerTest.php
@@ -12,10 +12,6 @@
 use OxidEsales\Eshop\Application\Model\User as EshopModelUser;
 use OxidEsales\ModuleTemplate\Controller\Admin\GreetingAdminController;
 use OxidEsales\ModuleTemplate\Core\Module as ModuleCore;
-use OxidEsales\ModuleTemplate\Model\GreetingTracker;
-use OxidEsales\ModuleTemplate\Model\User as ModuleUser;
-use OxidEsales\ModuleTemplate\Service\ModuleSettings;
-use OxidEsales\ModuleTemplate\Service\Repository;
 use OxidEsales\ModuleTemplate\Tests\Integration\IntegrationTestCase;
 use OxidEsales\ModuleTemplate\Traits\ServiceContainer;
 
@@ -31,8 +27,6 @@ final class GreetingAdminControllerTest extends IntegrationTestCase
 
     public const TEST_GREETING = 'Hello there!';
 
-    public const TEST_GREETING_UPDATED = 'shopping addict';
-
     public function testRender(): void
     {
         $this->createTestUser();

diff --git a/tests/Unit/Infrastructure/CoreRequestFactoryTest.php b/tests/Unit/Infrastructure/CoreRequestFactoryTest.php
@@ -20,10 +20,10 @@ class CoreRequestFactoryTest extends TestCase
 {
     public function testCreateProducesCorrectTypeOfObjects(): void
     {
-        $coreThemeFactoryMock = $this->getMockBuilder(CoreRequestFactory::class)
+        $coreRequestFactoryMock = $this->getMockBuilder(CoreRequestFactory::class)
             ->onlyMethods(['create'])
             ->getMock();
 
-        $this->assertInstanceOf(Request::class, $coreThemeFactoryMock->create());
+        $this->assertInstanceOf(Request::class, $coreRequestFactoryMock->create());
     }
 }
diff --git a/tests/Unit/Service/GreetingMessageTest.php b/tests/Unit/Service/GreetingMessageTest.php
@@ -9,7 +9,6 @@
 
 namespace OxidEsales\ModuleTemplate\Tests\Unit\Service;
 
-use OxidEsales\Eshop\Core\Request as CoreRequest;
 use OxidEsales\ModuleTemplate\Core\Module as ModuleCore;
 use OxidEsales\ModuleTemplate\Infrastructure\CoreRequestFactoryInterface;
 use OxidEsales\ModuleTemplate\Service\GreetingMessage;