OXDEV-8207: Fix wrong static key and named arguments for data providers

OXID-eSales · May 27, 2024 · 6460c66 · 6460c66
1 parent 309f6ec
commit 6460c66
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/tests/Integration/Greeting/Controller/GreetingControllerTest.php b/tests/Integration/Greeting/Controller/GreetingControllerTest.php
@@ -54,11 +54,11 @@ public function tearDown(): void
     /**
      * @dataProvider providerOemtGreeting
      */
-    public function testUpdateGreeting(bool $hasUser, string $mode, string $expected, int $count): void
+    public function testUpdateGreeting(bool $hasUser, string $mode, string $expect, int $count): void
     {
         $moduleSettings = $this->get(ModuleSettingsServiceInterface::class);
         $moduleSettings->saveGreetingMode($mode);
-        $_POST[ModuleCore::OEMT_GREETING_TEMPLATE_VARNAME] = $expected;
+        $_POST[ModuleCore::OEMT_GREETING_TEMPLATE_VARNAME] = $expect;
 
         $controller = oxNew(GreetingController::class);
 
@@ -71,7 +71,7 @@ public function testUpdateGreeting(bool $hasUser, string $mode, string $expected
         /** @var ModuleUser $user */
         $user = oxNew(EshopModelUser::class);
         $user->load(self::TEST_USER_ID);
-        $this->assertSame($expected, $user->getPersonalGreeting());
+        $this->assertSame($expect, $user->getPersonalGreeting());
 
         $tracker = $this->get(TrackerRepositoryInterface::class)
             ->getTrackerByUserId(self::TEST_USER_ID);
@@ -107,14 +107,14 @@ public static function providerOemtGreeting(): array
             'without_user_generic' => [
                 'hasUser' => false,
                 'mode' => ModuleSettingsServiceInterface::GREETING_MODE_GENERIC,
-                'expected' => '',
-                'count' => 0,
+                'expect'        => '',
+                'count'         => 0,
             ],
             'without_user_personal' => [
                 'hasUser' => false,
                 'mode' => ModuleSettingsServiceInterface::GREETING_MODE_PERSONAL,
-                'expected' => '',
-                'count' => 0,
+                'expect'        => '',
+                'count'         => 0,
             ],
             'with_user_generic' => [
                 'hasUser' => true,