OXDEV-8316 Make TrackerRepository readonly

metadata.php

@@ -16,7 +16,7 @@
 $aModule = [
     'id'          => 'oe_moduletemplate',
     'title'       => 'OxidEsales Module Template (OEMT)',
-    'description' =>  '',
+    'description' => 'Reusable module template with examples for the most common use cases',
     'thumbnail'   => 'pictures/logo.png',
     'version'     => '3.0.0',
     'author'      => 'OXID eSales AG',

src/Tracker/Repository/TrackerRepository.php

@@ -17,11 +17,11 @@
 /**
  * @extendable-class
  */
-class TrackerRepository implements TrackerRepositoryInterface
+readonly class TrackerRepository implements TrackerRepositoryInterface
 {
     public function __construct(
-        private readonly QueryBuilderFactoryInterface $queryBuilderFactory,
-        private readonly ContextInterface $context,
+        private QueryBuilderFactoryInterface $queryBuilderFactory,
+        private ContextInterface $context,
     ) {
     }
 

tests/Integration/Tracker/Service/TrackerServiceTest.php

@@ -14,7 +14,7 @@
 use OxidEsales\ModuleTemplate\Greeting\Model\PersonalGreetingUserInterface;
 use OxidEsales\ModuleTemplate\Greeting\Repository\GreetingRepositoryInterface;
 use OxidEsales\ModuleTemplate\Tracker\Model\TrackerModel;
-use OxidEsales\ModuleTemplate\Tracker\Repository\TrackerRepository;
+use OxidEsales\ModuleTemplate\Tracker\Repository\TrackerRepositoryInterface;
 use OxidEsales\ModuleTemplate\Tracker\Service\TrackerService;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
@@ -34,7 +34,7 @@ public function testUpdateTrackerNoGreetingChange(): void
             'getSavedUserGreeting' => self::TEST_GREETING
         ]);
 
-        $repo = $this->createPartialMock(TrackerRepository::class, ['getTrackerByUserId']);
+        $repo = $this->createPartialMock(TrackerRepositoryInterface::class, ['getTrackerByUserId']);
         $repo->expects($this->never())->method('getTrackerByUserId');
 
         $tracker = new TrackerService(
@@ -51,7 +51,7 @@ public function testUpdateTrackerGreetingChange(): void
             'getSavedUserGreeting' => self::TEST_GREETING . ' with a change'
         ]);
 
-        $repo = $this->createConfiguredStub(TrackerRepository::class, [
+        $repo = $this->createConfiguredStub(TrackerRepositoryInterface::class, [
             'getTrackerByUserId' => $trackerSpy = $this->createMock(TrackerModel::class)
         ]);
         $trackerSpy->expects($this->once())->method('countUp');