Skip to content

Commit

Permalink
Fix reported phpcs issues
Browse files Browse the repository at this point in the history
Signed-off-by: Anton Fedurtsya <[email protected]>
  • Loading branch information
Sieg committed Oct 2, 2023
1 parent 4b43080 commit 95a2767
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/development.yml
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ jobs:
continue-on-error: true
uses: actions/download-artifact@v3
with:
name: ModuleCodeceptionTestsLog-${{ inputs.php }}-${{ inputs.mysql }}
name: ModuleIntegrationTestsLog-${{ inputs.php }}-${{ inputs.mysql }}
path: ./

- name: List file structure
Expand Down
2 changes: 1 addition & 1 deletion src/Transition/Core/LanguageInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
interface LanguageInterface
{
public function getLanguageStringsArray(): array;
}
}
2 changes: 1 addition & 1 deletion src/Transition/Core/LanguageProxy.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ public function getLanguageStringsArray(): array
{
return $this->language->getLanguageStrings();
}
}
}
3 changes: 1 addition & 2 deletions src/Transition/Core/Response.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace OxidEsales\MediaLibrary\Transition\Core;


use OxidEsales\Eshop\Core\Utils;

class Response implements ResponseInterface
Expand All @@ -23,4 +22,4 @@ public function responseAsJavaScript(string $value): void
$this->utils->setHeader('Content-Type: application/javascript');
$this->utils->showMessageAndExit($value);
}
}
}
2 changes: 1 addition & 1 deletion src/Transition/Core/ResponseInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ interface ResponseInterface
public function responseAsJson(array $valueArray): void;

public function responseAsJavaScript(string $value): void;
}
}
4 changes: 2 additions & 2 deletions tests/Integration/Transition/Core/ResponseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function testRespondAsJson(): void
->with($jsonValue);

$correctHeaderSet = false;
$utilsMock->method('setHeader')->willReturnCallback(function ($value) use (&$correctHeaderSet){
$utilsMock->method('setHeader')->willReturnCallback(function ($value) use (&$correctHeaderSet) {
if (preg_match("@Content-Type:\s?application/json@i", $value)) {
$correctHeaderSet = true;
}
Expand All @@ -48,7 +48,7 @@ public function testRespondAsJavaScript(): void
->with($exampleData);

$correctHeaderSet = false;
$utilsMock->method('setHeader')->willReturnCallback(function ($value) use (&$correctHeaderSet){
$utilsMock->method('setHeader')->willReturnCallback(function ($value) use (&$correctHeaderSet) {
if (preg_match("@Content-Type:\s?application/javascript@i", $value)) {
$correctHeaderSet = true;
}
Expand Down

0 comments on commit 95a2767

Please sign in to comment.