chromium: update to 115.0.5790.170 #741

MaxIhlenfeldt · 2023-08-10T09:30:02Z

Release notes:
https://chromereleases.googleblog.com/2023/07/stable-channel-update-for-desktop.html
https://chromereleases.googleblog.com/2023/07/stable-channel-update-for-desktop_20.html
https://chromereleases.googleblog.com/2023/07/stable-channel-update-for-desktop_25.html
https://chromereleases.googleblog.com/2023/08/stable-channel-update-for-desktop.html

Build and patch changes:

Drop 0019-Backport-constexpr-std-string-fixes.patch,
0022-Backport-Avoid-capturing-structured-bindings.patch,
0026-Backport-std-string-ends_with-is-C-20.-Use-base-Ends.patch, and
0030-Backport-Avoid-operator-which-is-C-20-specific.patch as they are
included upstream now.

Add one more fix to 0018-Only-default-operator-on-declaration.patch,
which previously was part of
0030-Backport-Avoid-operator-which-is-C-20-specific.patch to prevent a
conflict. Also drop some fixes that are now included upstream.

Drop some fixes from 0021-Add-missing-typename-s.patch that are now
included upstream, and add two new ones.

Add one more fix to 0028-Avoid-capturing-structured-bindings.patch.

Add 0033-Revert-Reland-Reland-mte-refactor-the-tagging-functi.patch to
work around a bug in clang 14 that leads to a build error.

Add 0034-Avoid-parenthesized-initialization-of-aggregates.patch to fix
build errors with clang < 16.

Add 0035-Backport-IWYU-for-chromedriver-chrome-client_hints.h.patch to
fix a build error.

Rebase remaining patches.

License changes:

Added licenses:

third_party/beto-core/LICENSE

https://chromium-review.googlesource.com/c/chromium/src/+/4444306

third_party/devtools-frontend/src/front_end/third_party/puppeteer-replay/package/LICENSE

https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4480871

Removed licenses: none.

Updated licenses: none.

Test-built:

chromium-ozone-wayland:

mickledore, clang, MACHINE=qemuarm64
kirkstone, clang, MACHINE=raspberrypi4-64

chromium-x11

dunfell, clang**, MACHINE=raspberrypi4-64

** Please note that Chromium requires below set-up when on dunfell
branch.

The clang version to be >= 14 and for that, use the latest
meta-clang/dunfell-clang14 branch.
Require the latest meta-oe with Nodejs 14.x support.
Add the PREFERRED_VERSION_nodejs-native = "14.%" in conf/local.conf
file.

Signed-off-by: Max Ihlenfeldt [email protected]

MaxIhlenfeldt · 2023-08-10T09:30:28Z

I'll add the detailed description later, maybe you can please start testing already? @nrpt-m

nrpt-m · 2023-08-10T09:54:45Z

I'll add the detailed description later, maybe you can please start testing already? @nrpt-m

Sure, I am starting the testing.

MaxIhlenfeldt · 2023-08-10T14:06:08Z

Updated the commit message and PR description.

nrpt-m · 2023-08-11T05:32:06Z

@MaxIhlenfeldt
Have completed the builds & testing in master branch for all these below systems and chromium worked well in all these systems.

chromium-ozone-wayland: qemux86-64
chromium-x11: qemux86-64, qemuarm, qemuarm64, raspberrypi4-64

Next, starting with kirkstone, dunfell & mickledore branches.

MaxIhlenfeldt · 2023-08-11T09:48:41Z

Patch 0035-... has been merged upstream as https://crrev.com/c/4767547, so I updated the patch file (+ commit message and PR description) accordingly.

san-skov-dk · 2023-08-11T14:50:30Z

How to get meta-clang/dunfell-clang14 ?

MaxIhlenfeldt · 2023-08-11T15:01:29Z

The dunfell-clang14 branch is still experimental. Currently, you can find it at https://github.com/rakuco/meta-clang/tree/dunfell-clang14 (i.e. it lives in a fork).

rakuco

The changes look fine to me. The MTE patch is a bit scary, but I guess it's the best we can do at the moment.

I just have no idea what to do with the dunfell-clang14 branch :/

MaxIhlenfeldt · 2023-08-14T09:01:49Z

The MTE patch is a bit scary, but I guess it's the best we can do at the moment.

Not sure what you mean by scary, but luckily we can drop it once we use clang >= 15 everywhere.

I just have no idea what to do with the dunfell-clang14 branch :/

Me neither, but we definitely need it for this update. @kraj how do you suggest we proceed with kraj/meta-clang#835?

nrpt-m · 2023-08-14T09:36:27Z

Next, starting with kirkstone, dunfell & mickledore branches.

@MaxIhlenfeldt Have completed the builds & testing in kirkstone branch for all these below systems and chromium worked well in all these systems.

chromium-ozone-wayland: qemux86-64
chromium-x11: qemux86-64, qemuarm, qemuarm64, raspberrypi4-64

Next, starting with dunfell & mickledore branches.

nrpt-m · 2023-08-14T10:20:28Z

@MaxIhlenfeldt ,
I am getting errors while building all the machines in dunfell branch. Have attached the build errors here.
chromium-115.0.5790.170-dunfell-build-errors.txt

Could you please check these errors.

rakuco · 2023-08-14T10:23:00Z

@nrpt-m Is PREFERRED_VERSION_nodejs-native = "14.%" set in local.conf? These look like nodejs errors that we used to get in Node 12.

nrpt-m · 2023-08-14T10:37:00Z

@nrpt-m Is PREFERRED_VERSION_nodejs-native = "14.%" set in local.conf? These look like nodejs errors that we used to get in Node 12.

Sorry, I missed it "PREFERRED_VERSION_nodejs-native = "14.%".

MaxIhlenfeldt · 2023-08-15T10:43:33Z

FYI, I'll be ooo tomorrow and the rest of the week. I suppose it's a bit optimistic, but should there be progress regarding the dunfell-clang14 branch that means we can merge this PR, feel free to take this over and merge it without me.

nrpt-m · 2023-08-15T18:05:31Z

@MaxIhlenfeldt @rakuco ,
Have completed the builds & testing in dunfell branch for all these below systems and all the systems worked well except rpi4.

chromium-ozone-wayland: qemux86-64
chromium-x11: qemux86-64, qemuarm, qemuarm64, raspberrypi4-64**

**RPi4/dunfell the "network service crashed" problem is still there.
Next is mickledore branch.

nrpt-m · 2023-08-17T04:46:14Z

**RPi4/dunfell the "network service crashed" problem is still there. Next is mickledore branch.

@MaxIhlenfeldt & @rakuco
Have completed the builds & testing in mickledore branch for all these below systems and chromium worked well in all these systems.

chromium-ozone-wayland: qemux86-64
chromium-x11: qemux86-64, qemuarm, qemuarm64, raspberrypi4-64

If you are agree with all these above test results then, we are good to go for merge.

rakuco · 2023-08-17T07:15:24Z

Thank you for testing! Everything looks fine from my side too, but we need to figure out the dunfell-clang14 situation first.

Release notes: https://chromereleases.googleblog.com/2023/07/stable-channel-update-for-desktop.html https://chromereleases.googleblog.com/2023/07/stable-channel-update-for-desktop_20.html https://chromereleases.googleblog.com/2023/07/stable-channel-update-for-desktop_25.html https://chromereleases.googleblog.com/2023/08/stable-channel-update-for-desktop.html Build and patch changes: ------------------------ Drop 0019-Backport-constexpr-std-string-fixes.patch, 0022-Backport-Avoid-capturing-structured-bindings.patch, 0026-Backport-std-string-ends_with-is-C-20.-Use-base-Ends.patch, and 0030-Backport-Avoid-operator-which-is-C-20-specific.patch as they are included upstream now. Add one more fix to 0018-Only-default-operator-on-declaration.patch, which previously was part of 0030-Backport-Avoid-operator-which-is-C-20-specific.patch to prevent a conflict. Also drop some fixes that are now included upstream. Drop some fixes from 0021-Add-missing-typename-s.patch that are now included upstream, and add two new ones. Add one more fix to 0028-Avoid-capturing-structured-bindings.patch. Add 0033-Revert-Reland-Reland-mte-refactor-the-tagging-functi.patch to work around a bug in clang 14 that leads to a build error. Add 0034-Avoid-parenthesized-initialization-of-aggregates.patch to fix build errors with clang < 16. Add 0035-Backport-IWYU-for-chromedriver-chrome-client_hints.h.patch to fix a build error. Rebase remaining patches. License changes: ---------------- Added licenses: * third_party/beto-core/LICENSE - https://chromium-review.googlesource.com/c/chromium/src/+/4444306 * third_party/devtools-frontend/src/front_end/third_party/puppeteer-replay/package/LICENSE - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4480871 Removed licenses: none. Updated licenses: none. Test-built: ----------- * chromium-ozone-wayland: - mickledore, clang, MACHINE=qemuarm64 - kirkstone, clang, MACHINE=raspberrypi4-64 * chromium-x11 - dunfell, clang**, MACHINE=raspberrypi4-64 ** Please note that Chromium requires below set-up when on dunfell branch. - The clang version to be >= 14 and for that, use the latest meta-clang/dunfell-clang14 branch. - Require the latest meta-oe with Nodejs 14.x support. - Add the PREFERRED_VERSION_nodejs-native = "14.%" in conf/local.conf file. Signed-off-by: Max Ihlenfeldt <[email protected]>

nrpt-m · 2023-08-31T13:43:09Z

@rakuco ,
Is there any particular reason for not merging dunfell-clang14 branch yet ? It's been two weeks that we have finished the testing for chromium-115.

rakuco

The dunfell-clang14 branch was finally created in meta-clang last Friday, so I'll go ahead and merge this PR while Max is OoO.

MaxIhlenfeldt requested a review from rakuco August 10, 2023 09:30

MaxIhlenfeldt linked an issue Aug 10, 2023 that may be closed by this pull request

Update to chromium 115 #734

Closed

MaxIhlenfeldt force-pushed the 115.0.5790.170 branch from b90eb06 to fcbb743 Compare August 10, 2023 14:05

MaxIhlenfeldt force-pushed the 115.0.5790.170 branch from fcbb743 to f549ba4 Compare August 11, 2023 09:47

rakuco reviewed Aug 14, 2023

View reviewed changes

This was referenced Aug 21, 2023

Update to chromium 116 #744

Closed

chromium: Disable Rust for now #745

Merged

MaxIhlenfeldt force-pushed the 115.0.5790.170 branch from f549ba4 to ca9f34e Compare August 29, 2023 10:43

MaxIhlenfeldt force-pushed the 115.0.5790.170 branch from ca9f34e to 6615360 Compare August 29, 2023 10:44

MaxIhlenfeldt mentioned this pull request Sep 7, 2023

chromium: update to 116.0.5845.179 #750

Merged

rakuco approved these changes Sep 11, 2023

View reviewed changes

rakuco merged commit 939024c into OSSystems:master Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chromium: update to 115.0.5790.170 #741

chromium: update to 115.0.5790.170 #741

MaxIhlenfeldt commented Aug 10, 2023 •

edited

Loading

MaxIhlenfeldt commented Aug 10, 2023

nrpt-m commented Aug 10, 2023

MaxIhlenfeldt commented Aug 10, 2023

nrpt-m commented Aug 11, 2023

MaxIhlenfeldt commented Aug 11, 2023

san-skov-dk commented Aug 11, 2023

MaxIhlenfeldt commented Aug 11, 2023

rakuco left a comment

MaxIhlenfeldt commented Aug 14, 2023

nrpt-m commented Aug 14, 2023

nrpt-m commented Aug 14, 2023

rakuco commented Aug 14, 2023

nrpt-m commented Aug 14, 2023

MaxIhlenfeldt commented Aug 15, 2023

nrpt-m commented Aug 15, 2023

nrpt-m commented Aug 17, 2023

rakuco commented Aug 17, 2023

nrpt-m commented Aug 31, 2023

rakuco left a comment

chromium: update to 115.0.5790.170 #741

chromium: update to 115.0.5790.170 #741

Conversation

MaxIhlenfeldt commented Aug 10, 2023 • edited Loading

Build and patch changes:

License changes:

Test-built:

MaxIhlenfeldt commented Aug 10, 2023

nrpt-m commented Aug 10, 2023

MaxIhlenfeldt commented Aug 10, 2023

nrpt-m commented Aug 11, 2023

MaxIhlenfeldt commented Aug 11, 2023

san-skov-dk commented Aug 11, 2023

MaxIhlenfeldt commented Aug 11, 2023

rakuco left a comment

Choose a reason for hiding this comment

MaxIhlenfeldt commented Aug 14, 2023

nrpt-m commented Aug 14, 2023

nrpt-m commented Aug 14, 2023

rakuco commented Aug 14, 2023

nrpt-m commented Aug 14, 2023

MaxIhlenfeldt commented Aug 15, 2023

nrpt-m commented Aug 15, 2023

nrpt-m commented Aug 17, 2023

rakuco commented Aug 17, 2023

nrpt-m commented Aug 31, 2023

rakuco left a comment

Choose a reason for hiding this comment

MaxIhlenfeldt commented Aug 10, 2023 •

edited

Loading