Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n configuration for system installed captions #4011

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Add i18n configuration for system installed captions #4011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c887e5
Add system apps caption translation
ahmed-mgd Dec 12, 2024
99bf2d9
Use I18n for caption
ahmed-mgd Dec 12, 2024
cb0b4fd
Refactor caption and category instance variables into methods
ahmed-mgd Dec 12, 2024
a39a5dd
Restore dev_router.rb
ahmed-mgd Dec 16, 2024
0a9127b
Refactor sys_router.rb to match dev_router.rb
ahmed-mgd Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions apps/dashboard/app/apps/sys_router.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# The router class for all system apps.
class SysRouter
attr_reader :name
attr_reader :name, :owner, :caption, :category

#TODO: consider making SysRouter a subclass of
# OodAppkit::Url
Expand All @@ -23,6 +23,9 @@ def self.apps

def initialize(name)
@name = name.to_s
@owner = :sys
@caption = I18n.t('dashboard.system_apps_caption')
@category = ""
end

def token
Expand All @@ -37,18 +40,6 @@ def type
:sys
end

def owner
:sys
end

def caption
"System Installed App"
end

def category
""
end

def url
"/pun/sys/#{name}"
end
Expand Down
3 changes: 2 additions & 1 deletion apps/dashboard/config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ en:
<pre>%{exception_message}</pre>
<h4>Stack trace:</h4>
<pre>%{exception_trace}</pre>
apps_system_apps_title: "System Apps"
apps_system_apps_title: "System Apps" # Not used anywhere
system_apps_caption: "System Installed App"

shell_app_title: "%{cluster_title} Shell Access"

Expand Down
Loading