657 automate localizations #4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazelGrant
force-pushed
the
657-automate_localizations
branch
2 times, most recently
from
99933bf to
443b854
Compare
HazelGrant
force-pushed
the
657-automate_localizations
branch
from
283123e to
c2f41c7
Compare
HazelGrant
force-pushed
the
657-automate_localizations
branch
from
a95a5fe to
f138ed4
Compare
HazelGrant
commented
Dec 18, 2024
apps/dashboard/Gemfile
Outdated
| @@ -39,6 +39,10 @@ end | |||
| group :development do | |||
| # Access an IRB console on exception pages or by using <%= console %> in views | |||
| # gem 'web-console', '~> 2.0' | |||
| gem 'i18n-tasks' | |||
| gem 'highline', '2.1.0' | |||
| gem 'easy_translate' | |||
There was a problem hiding this comment.
'easy_translate' and 'ruby-openai' bring in gem incompatibilities with Ruby 2.7. However, running bundle exec i18n-tasks translate-missing (which requires these two gems) translates zero keys. Do we need this?
There was a problem hiding this comment.
Do we need this?
I think longer term we will. Maybe we just can't automatic updates this until we drop 2.7 support?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #657