Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job name prefix just before job submit. #3887

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Add job name prefix just before job submit. #3887

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddeae95
Check for path in job name before finalizing it.
euler-room Oct 21, 2024
b4623c2
Merge branch 'master' into 3794-BUG-fix-auto-job-name-duplicate-path
euler-room Oct 24, 2024
a9f1115
Only add prefix to auto_job_name just before submit.
euler-room Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/dashboard/app/lib/smart_attributes/attributes/auto_job_name.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class AutoJobName < Attribute
# Defaults to ondemand/[dev,sys]/projects
# @return [String] attribute value
def value
job_name(opts[:value] || 'Project Manager Job')
opts[:value] || 'Project Manager Job'
end

def widget
Expand All @@ -32,7 +32,7 @@ def label(*)
# @param fmt [String, nil] formatting of hash
# @return [Hash] submission hash
def submit(*)
{ script: { job_name: value } }
{ script: { job_name: job_name(value) } }
end

# TODO: need to sanitize the job name for some schedulers
Expand Down
Loading