greatly simplify snakeCaseWords #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
commented
Oct 17, 2024
.github/workflows/tests.yml
Outdated
| @@ -45,7 +45,7 @@ jobs: | |||
| uses: actions/cache@v3 | |||
| with: | |||
| path: ~/vendor/bundle | |||
| key: ${{ runner.os }}-${{ matrix.ruby }}-unit-gems-${{ hashFiles('apps/*/Gemfile.lock', 'Gemfile.lock') }}-1 | |||
| key: ${{ runner.os }}-${{ matrix.ruby }}-unit-gems-${{ hashFiles('apps/*/Gemfile.lock', 'Gemfile.lock') }}-2 | |||
There was a problem hiding this comment.
Not really a part of this, but tests started failing with error, so we need to update those gems.
LoadError: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found
(required by /home/runner/vendor/bundle/ruby/3.0.0/gems/date-3.3.4/lib/date_core.so)
- /home/runner/vendor/bundle/ruby/3.0.0/gems/date-3.3.4/lib/date_core.so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3538
First, I want to see how this tests, because I'm not 100% sure on it. I think it works for most cases, but tests will tell the tale.
Looking through the
git blameI can see that #2158 added a lot of complication to fix #1658, but looking at #1658 a second time, I wonder if that even matters.The issue in #1658 complained about mapping
OSC_JUPYTERtoo_s_c_j_u_p_y_t_e_r. But the issue is that this mapping is done to normalize keys in the tables. I'm thinking now that that odd mapping doesn't really matter. As long as it's consistent, what's it matter?