script#edit don't allow user to remove last option #3844
Conversation
|
I feel like there's a ticket for being unable to remove script & cluster. Like you can't ever remove these 2 things, ever. The system just can't do anything if those 2 aren't supplied. |
|
🤦♂️ you linked the ticket I was thinking about, but even in that ticket (that I wrote lol) I didn't mention these 2 fields script and cluster. Looking now I see that |
|
Maybe I misunderstood exactly what the ticket was saying? In an individual dropdown select (i.e. |
Sorry, it's me who's mis-understaing. Yes I think you're correct, and I'll take a look at this sometime soon (I'm a bit snowed in with 3.1 and some cardinal stuff). |
| @@ -34,7 +35,7 @@ | |||
|
|
|||
| <button class="btn btn-warning float-end" type="button" id="<%= remove_id %>" | |||
| data-select-toggler="remove" data-select-id="<%= field_id %>" | |||
| <%= disabled ? 'disabled="true"'.html_safe : nil %> > | |||
| <%= disabled || last_option ? 'disabled="true"'.html_safe : nil %> > | |||
There was a problem hiding this comment.
We should avoid using html_safe. Here it's just text so it should be fine. Not sure why the original code used it, I must not have caught it then.
|
This works well for me and indeed I think I like the UX better that what we have now (with the alert). I think I just have one little thing with the |
Fixes #3050
Disables the remove button for the last option.
Note that this does not actually fix the attribute, just removes the ability for the user to click the remove button on the last option.
If we want to fix the option, it might make sense to allow the user to unfix the attribute by adding an item another item instead of disabling all of them. Otherwise, if the the attribute was fixed when there is only one option left, the "Fixed" checkbox would need to be unchecked and some arbitrary second option would need to be enabled.