Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix for apache 2.4.62 - Update node_proxy.lua" #3823

Closed
wants to merge 1 commit into from

Conversation

johrstrom
Copy link
Contributor

Reverts #3776

Testing this in 3.1.8 has issues with Rstudio. You can see here the ?dark=0&refresh=1 is being url encoded and added to the URL, while they appear again correctly ?dark=0&refresh=1. Of course Rstudio returns a 404 here because it thinks that's still a part of the URL.

2024-09-24T17:37:11.332015Z [rserver] DEBUG - Start server proxy request GET /theme/default/solarized_light.rstheme%3Fdark=0&refresh=1?dark=0&refresh=1 (johrstrom:113) for local stream: /tmp/run/rstudio-rsession/johrstrom-d
2024-09-24T17:37:11.334152Z [rserver] DEBUG -- sent server proxy response for: /theme/default/solarized_light.rstheme%3Fdark=0&refresh=1?dark=0&refresh=1 (johrstrom:113) in 0.2s id:: 404

@johrstrom
Copy link
Contributor Author

Instead of reverting this - I think I'll actually just apply a patch on top of it.

@johrstrom johrstrom closed this Sep 24, 2024
@johrstrom johrstrom deleted the revert-3776-master branch September 24, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants