Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes NavConfig class & Replaces its use #3475

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Removes NavConfig class & Replaces its use #3475

merged 4 commits into from
Apr 11, 2024

Conversation

HazelGrant
Copy link
Contributor

Fixes #2255

@HazelGrant HazelGrant force-pushed the 2255-remove-navconfig branch from f74f6bd to d554aec Compare April 9, 2024 13:48
@HazelGrant HazelGrant marked this pull request as ready for review April 9, 2024 14:21
@HazelGrant HazelGrant requested a review from johrstrom April 9, 2024 14:21
@johrstrom
Copy link
Contributor

Shouldn't this remove the NavConfig.rb file too?

johrstrom
johrstrom approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HazelGrant HazelGrant merged commit 6e627c0 into master Apr 11, 2024
23 checks passed
@HazelGrant HazelGrant deleted the 2255-remove-navconfig branch April 11, 2024 13:18
@osc-bot osc-bot mentioned this pull request Apr 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johrstrom johrstrom johrstrom approved these changes

Assignees
No one assigned
Labels
component/dashboard needs doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove NavConfig
3 participants
@HazelGrant @johrstrom @osc-bot