Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pathfinger_select widget with data-hide option #3460

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

HazelGrant
Copy link
Contributor

Fixes #3425

With the following form.yml:

form:
  - path
  - hide_path
attributes:
  path:
    widget: 'path_selector'
  hide_path:
    widget: 'select'
    options:
      - ['show path', 'show path']
      - ['hide path', 'hide path', data-hide-path: true]
Screen.Recording.2024-03-26.at.12.04.03.PM.mov

@HazelGrant HazelGrant marked this pull request as ready for review March 26, 2024 17:07
@HazelGrant HazelGrant requested a review from johrstrom March 26, 2024 17:08
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine. Checking bootstrap-ruby the class form-group isn't used anymore.

We're going to be in some pain when we upgrade to bootstrap 5 so I'll be sure to make the ticket now and link to this PR so we know at least this is 1 area where we'll need some updates.

@johrstrom johrstrom mentioned this pull request Mar 26, 2024
9 tasks
@HazelGrant HazelGrant merged commit c356c5c into master Mar 26, 2024
20 checks passed
@HazelGrant HazelGrant deleted the 3425-data-hide-pathfinder-button branch March 26, 2024 17:43
@johrstrom johrstrom mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-hide does not hide the button for path_selector
3 participants