3081 - auto_environment_variables #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there's a way to simplify this where the value in the form doesn't have both the key and value of the environment variable. I'm thinking we can embed the environment variable's key in the form's key. Then the value becomes just the value for both. |
johrstrom
reviewed
Mar 19, 2024
johrstrom
reviewed
Mar 19, 2024
apps/dashboard/app/views/launchers/editable_form_fields/_editable_text_field.erb
Outdated
Show resolved
Hide resolved
johrstrom
reviewed
Mar 21, 2024
apps/dashboard/app/lib/smart_attributes/attributes/auto_environment_variable.rb
Outdated
Show resolved
Hide resolved
johrstrom
reviewed
Mar 21, 2024
johrstrom
reviewed
Mar 21, 2024
apps/dashboard/app/lib/smart_attributes/attributes/auto_environment_variable.rb
Outdated
Show resolved
Hide resolved
johrstrom
reviewed
Mar 21, 2024
apps/dashboard/app/views/launchers/editable_form_fields/_editable_text_field.erb
Outdated
Show resolved
Hide resolved
johrstrom
reviewed
Mar 21, 2024
johrstrom
reviewed
Mar 21, 2024
apps/dashboard/app/lib/smart_attributes/attributes/auto_environment_variable.rb
Show resolved
Hide resolved
they can't see the name of the variable in the form.
johrstrom
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3081
Updated Video Mar. 28 2024:
Screen.Recording.2024-03-28.at.10.05.21.AM.mov