Arbitrary apache conf

[johrstrom]

This adds the ability to add arbitrary things to the location and vhost in our apache config.

Fixes #708
Fixes #3240

Though now re-reading 708 I'm seeing multiline strings may not be the best option - I just want to be sure folks can add XML structures as well as single line directives.

[CSC-swesters]

Thank you for working on this issue!

I agree with Treydock's comment: #708 (comment)
The support for a list of lines in the YAML would be valuable to us, since we use Puppet for some of our environments.

I suppose you could support both ways by checking for the data type in the Ruby template? If the type of the @custom_vhost_directives variable is a string, do what your PR does currently. And if it's a list, just do @custom_vhost_directives.each do |line| instead, I suppose.

This would require some additional test cases, but I think both ways could be supported.

[johrstrom]

Thanks, yea I changed to arrays of strings. I think it'll be OK to just support one thing - I'm testing here for correct indentation and I think that's the only thing that would be required here - that things, say in a new are formatted correctly.

[Oglopf]

This all looks good, but there is a merge conflict in the spec file for a test. Should be fine after that gets fixed.

[Oglopf]

Looks good!

[xpillons]

@johrstrom in which release this is now included ? I don't find any references in the changelogs.

[johrstrom]

It's in 3.1

https://osc.github.io/ood-documentation/latest/release-notes/v3.1-release-notes.html#updated-apache-options

And just to be sure I checked the changelog too.

ondemand/CHANGELOG.md

Line 60 in 1df70e5

- Sites can now set arbitrary vhost and location directives in Arbitrary apache conf [3293](https://github.com/OSC/ondemand/pull/3293).

[xpillons]

Thank you for confirming, I was looking at the release change log https://github.com/OSC/ondemand/releases not the one in the documentation